From: David Miller <davem@davemloft.net>
To: agl@imperialviolet.org
Cc: netdev@vger.kernel.org
Subject: Re: Comments requested: Long options and MD5 options
Date: Wed, 18 Jun 2008 16:36:51 -0700 (PDT) [thread overview]
Message-ID: <20080618.163651.50869440.davem@davemloft.net> (raw)
In-Reply-To: <396556a20805301217k293e5718h6bbf02bfe0683145@europa>
From: "Adam Langley" <agl@imperialviolet.org>
Date: Wed, 18 Jun 2008 16:24:33 -0700
> > The retransmit timeout timer has to fire eventually, and when
> > that happens we should clear all of our SACK state.
>
> Ok, that's good at least. There were other variables in my test that could have
> screwed that up.
>
> Attached is a patch which pulls the options logic together into a single
> function of SYN/SYNACK and one for established. At the moment, it chooses
> SACK over timestamps for MD5 connections, but it's very easy to change. (And
> that's the point of this patch - the logic isn't spread out)
>
> Not signed off, because I want to do more testing, and to sleep on it first,
> but pretty close to final.
Thanks for doing this work, I'll have a closer look at this
patch later this evening.
next prev parent reply other threads:[~2008-06-18 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 21:52 [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2) Adam Langley
2008-06-18 0:07 ` David Miller
2008-06-18 0:45 ` Adam Langley
2008-06-18 4:03 ` David Miller
2008-06-18 6:34 ` Bill Fink
2008-06-18 8:52 ` David Miller
2008-06-18 19:39 ` Adam Langley
2008-06-18 22:01 ` David Miller
2008-06-18 23:24 ` Comments requested: Long options and MD5 options Adam Langley
2008-06-18 23:36 ` David Miller [this message]
2008-06-20 20:27 ` [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled (v2) Adam Langley
2008-06-28 2:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618.163651.50869440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agl@imperialviolet.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).