From: Christoph Hellwig <hch@infradead.org>
To: Subbu Seetharaman <subbus@serverengines.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
jeff@garzik.org, netdev@vger.kernel.org,
sathyap@serverengines.com
Subject: Re: [PATCH 3/12] benet: net_object i/f functions, Makefile
Date: Thu, 19 Jun 2008 06:01:51 -0400 [thread overview]
Message-ID: <20080619100151.GA24434@infradead.org> (raw)
In-Reply-To: <20080619095919.cf02dbe3@mailhost.serverengines.com>
On Thu, Jun 19, 2008 at 02:59:19AM -0700, Subbu Seetharaman wrote:
> Christoph,
>
> The primary reason for separating the lower layer
> code from rest of the driver is to share it
> across two drivers for the two functions
> of the device.
Then please look at the various drivers that already do this. Just
built each module on it's own without strange cross-directory builds.
> The secondary objective of
> keeping this code OS neutral through
> abstractions has been conceded based
> on the review comments from the last few
> rounds.
But that's not how the code looks like. There's still tons and tons
of useless wrappers that just make the code unreadable.
next prev parent reply other threads:[~2008-06-19 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 9:59 [PATCH 3/12] benet: net_object i/f functions, Makefile Subbu Seetharaman
2008-06-19 10:01 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 6:27 Subbu Seetharaman
2008-06-19 9:11 ` Christoph Hellwig
2008-06-18 16:20 Subbu Seetharaman
2008-06-18 18:41 ` Sam Ravnborg
2008-06-12 10:40 Subbu Seetharaman
2008-06-17 19:26 ` Sam Ravnborg
2008-06-19 10:13 ` Christoph Hellwig
2008-06-19 10:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619100151.GA24434@infradead.org \
--to=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sathyap@serverengines.com \
--cc=subbus@serverengines.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).