From: Stephen Hemminger <shemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
Kieran Mansley <kmansley@solarflare.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs [2nd try]
Date: Thu, 19 Jun 2008 14:50:09 -0700 [thread overview]
Message-ID: <20080619145009.5b24f028@extreme> (raw)
In-Reply-To: <cover.1213898165.git.bhutchings@solarflare.com>
On Thu, 19 Jun 2008 19:44:56 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> [Re-sent with the correct Message-ID, previously eaten by mutt.]
>
> Large Receive Offload (LRO) destroys packet headers that should be
> preserved when forwarding. Currently it also triggers a BUG() or WARN()
> in skb_gso_segment(). We should disable it wherever forwarding is
> enabled, and discard LRO skbs with a warning if it is turned back on.
>
> Since the previous version of these patches, I have:
> - Tightened the test for LRO'd skbs, so it should not catch skbs from
> VM guests that want GSO
> - Made the test an inline function, with the warning a separate extern
> function
> - Rebased against net-next-2.6
>
I like that it covers both cases and looks clean. If anyone ever gets
around to rewriting the network device driver chapter in the linux
kernel book(s) this should be covered in more detail.
next prev parent reply other threads:[~2008-06-19 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 18:44 [PATCH 0/2] Disable forwarding of LRO skbs [2nd try] Ben Hutchings
2008-06-19 18:07 ` [PATCH 1/2] net: Disable LRO on devices that are forwarding Ben Hutchings
2008-06-19 23:21 ` David Miller
2008-06-20 11:11 ` Ben Hutchings
2008-06-20 11:17 ` Patrick McHardy
2008-06-20 14:21 ` Andi Kleen
2008-06-19 18:08 ` [PATCH 2/2] net: Discard and warn about LRO'd skbs received for forwarding Ben Hutchings
2008-06-19 21:50 ` Stephen Hemminger
2008-06-19 22:29 ` Brandeburg, Jesse
2008-06-19 22:42 ` Ben Hutchings
2008-06-19 23:27 ` David Miller
2008-06-19 21:50 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 18:06 [PATCH 0/2] Disable forwarding of LRO skbs [2nd try] Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080619145009.5b24f028@extreme \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kmansley@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).