* [PATCH 0/3]: v2 of "TX backlog management in-driver..."
@ 2008-06-20 23:16 David Miller
2008-06-21 6:20 ` Michael Chan
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-06-20 23:16 UTC (permalink / raw)
To: netdev; +Cc: vinay, krkumar2, mchan
Changes since first version:
1) Integrate TSO fixes and cleanups from Michael Chan into
patch one. Michael if I could have your signoff on that
one, I'd appreciate it.
2) Patch three attempts to deal with the reordering issue and
races as follows:
a) ->hard_start_xmit() considers the TX ring full if any
packets are in the TX backlog queue. This ensures that
the backlog is fully empties before fresh ->hard_start_xmit()
packets can be put onto the TX ring
b) Mimicking the existing netif_{stop,wake}_queue() machinery,
tg3_tx() and ->hard_start_xmit() cooperate to make updates,
tests, and memory barriers such that the the TX backlog will
not get wedged. There are extensive comments added to the
code in this patch which tries to explain how this works.
Patch two is essentially unchanged.
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3]: v2 of "TX backlog management in-driver..."
2008-06-21 6:20 ` Michael Chan
@ 2008-06-21 6:20 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-06-21 6:20 UTC (permalink / raw)
To: mchan; +Cc: netdev, vinay, krkumar2
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 20 Jun 2008 23:20:36 -0700
> Patch 1 looks good to me.
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Thanks for looking at it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3]: v2 of "TX backlog management in-driver..."
2008-06-20 23:16 [PATCH 0/3]: v2 of "TX backlog management in-driver..." David Miller
@ 2008-06-21 6:20 ` Michael Chan
2008-06-21 6:20 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Michael Chan @ 2008-06-21 6:20 UTC (permalink / raw)
To: David Miller
Cc: netdev@vger.kernel.org, vinay@linux.vnet.ibm.com,
krkumar2@in.ibm.com
David Miller wrote:
> Changes since first version:
>
> 1) Integrate TSO fixes and cleanups from Michael Chan into
> patch one. Michael if I could have your signoff on that
> one, I'd appreciate it.
>
Patch 1 looks good to me.
Signed-off-by: Michael Chan <mchan@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-21 6:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-20 23:16 [PATCH 0/3]: v2 of "TX backlog management in-driver..." David Miller
2008-06-21 6:20 ` Michael Chan
2008-06-21 6:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).