From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@redhat.com>
Cc: netdev@vger.kernel.org
Subject: [patch] fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource'
Date: Fri, 20 Jun 2008 11:33:16 +0200 [thread overview]
Message-ID: <20080620093316.GA19003@elte.hu> (raw)
commit 2538003ce2ea0b936d273692bc4e51c5b52fe70d
Author: Ingo Molnar <mingo@elte.hu>
Date: Fri Jun 20 11:29:31 2008 +0200
fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource'
-tip testing found the following build failure:
drivers/built-in.o: In function `corkscrew_setup':
3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource'
which happens if 3c515.c is build without CONFIG_PNP:
http://redhat.com/~mingo/misc/config-Fri_Jun_20_10_02_43_CEST_2008.bad
the reason is pnp_irq() use outside of its __ISAPNP__ section.
corkscrew_setup() always called with NULL in the !__ISAPNP__ case, but
also check this condition to make sure.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/drivers/net/3c515.c b/drivers/net/3c515.c
index 105a8c7..09dd063 100644
--- a/drivers/net/3c515.c
+++ b/drivers/net/3c515.c
@@ -573,7 +573,12 @@ static int corkscrew_setup(struct net_device *dev, int ioaddr,
DECLARE_MAC_BUF(mac);
if (idev) {
+#ifdef __ISAPNP__
irq = pnp_irq(idev, 0);
+#else
+ /* Can not happen - in the !PNP case we always pass in NULL */
+ BUG_ON(1);
+#endif
vp->dev = &idev->dev;
} else {
irq = inw(ioaddr + 0x2002) & 15;
next reply other threads:[~2008-06-20 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 9:33 Ingo Molnar [this message]
2008-06-20 15:13 ` [patch] fix 3c515.c:(.text+0x57200): undefined reference to `pnp_get_resource' Randy Dunlap
2008-06-20 15:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620093316.GA19003@elte.hu \
--to=mingo@elte.hu \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).