From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: /proc/net/tcp rto,ato values not scaled properly
Date: Fri, 20 Jun 2008 12:31:12 -0700 [thread overview]
Message-ID: <20080620123112.26202db9@extreme> (raw)
In-Reply-To: <20080620.120526.246965779.davem@davemloft.net>
On Fri, 20 Jun 2008 12:05:26 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 20 Jun 2008 11:56:03 -0700
>
> > I found another case where we are sending information to userspace
> > in the wrong HZ scale. This should have been fixed back in 2.5 :-(
> >
> > This means an ABI change but as it stands there is no way for an application
> > like ss to get the right value.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Agree with your patch, but 'ss' should be getting this kind of info
> from netlink not procfs, right?
>
Yes, ss tries netlink first and fallsback to /proc.
I am in process of making sure all usages of HZ in iproute utilities
are correct. The old user code assumed that the hz value used by tc (psched)
was also correct for lots of other places. That is where I keep finding
these turds.
Soon all uses of get_hz() in iproute will be replaced with
either get_psched_hz() for tc; get_user_hz for clock
values, or just use ms or us.
next prev parent reply other threads:[~2008-06-20 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 18:56 [PATCH] tcp: /proc/net/tcp rto,ato values not scaled properly Stephen Hemminger
2008-06-20 19:05 ` David Miller
2008-06-20 19:31 ` Stephen Hemminger [this message]
2008-06-21 5:19 ` David Miller
2008-06-23 18:16 ` [PATCH] tcp: /proc/net/tcp rto,ato values not scaled properly (v2) Stephen Hemminger
2008-06-28 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080620123112.26202db9@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).