Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

[Octavian Purdila <opurdila@ixiacom.com>]

On Saturday 21 June 2008, Jarek Poplawski wrote:

>
> Hmm..., I hope my ack will not hinder too much...
>

No, it actually helped making this a better patch and me learning a great 
deal.


> PS: I see this other "readability" patch seems to change even more, so
> I'll really need some free time to figure this out.
>

Sure, no hurry. To be honest this is a rewrite which I started to see if I 
understand the tcp read splice path properly. It ended up being cleaner than 
the original code so I thought I should share this - but of course being the 
one who wrote it I am completely biased on that assessment. So if it is not 
obviously more "readable" to someone else, than its probably not worth 
spending too much time on it  since we already have working / tested code :)

Thanks,
tavi