From: David Miller <davem@davemloft.net>
To: peter.p.waskiewicz.jr@intel.com
Cc: bunk@kernel.org, kaber@trash.net, netdev@vger.kernel.org,
rpjday@crashcourse.ca
Subject: Re: [2.6 patch] remove CONFIG_NET_SCH_RR
Date: Mon, 23 Jun 2008 14:52:31 -0700 (PDT) [thread overview]
Message-ID: <20080623.145231.223738833.davem@davemloft.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC3290549C885@orsmsx414.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 23 Jun 2008 11:31:30 -0700
> >Commit d62733c8e437fdb58325617c4b3331769ba82d70
> >([SCHED]: Qdisc changes and sch_rr added for multiqueue)
> >added a NET_SCH_RR option that was unused since the code
> >went unconditionally into sch_prio.
>
> I don't agree we should remove this option, purely for the fact that
> there isn't any way a user would know the qdisc existed without reading
> the code.
That's not how config options work.
We add features and facilities all the time that lack CONFIG
option entries.
And frankly, I plan on removing the RR scheduler in the TX
multiqueue bits I'm doing.
But even if I didn't plan this, we should remove these unused
CONFIG variables, because that is our tree wide policy. We
don't use them as dinky knobs for documentation.
next prev parent reply other threads:[~2008-06-23 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 17:47 [2.6 patch] remove CONFIG_NET_SCH_RR Adrian Bunk
2008-06-23 18:31 ` Waskiewicz Jr, Peter P
2008-06-23 19:18 ` Patrick McHardy
2008-06-23 19:40 ` Adrian Bunk
2008-06-23 19:59 ` Waskiewicz Jr, Peter P
2008-06-23 21:52 ` David Miller [this message]
2008-06-28 2:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623.145231.223738833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bunk@kernel.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).