From: Ben Dooks <ben-linux@fluff.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
netdev@vger.kernel.org, jeff@garzik.org,
Bryan Wu <cooloney@kernel.org>,
Laurent Pinchart <laurentp@cse-semaphore.com>
Subject: Re: [patch v2 02/11] DM9000: Fixup blackfin after removing 2 resource usage
Date: Mon, 23 Jun 2008 10:24:07 +0100 [thread overview]
Message-ID: <20080623092407.GD26276@fluff.org.uk> (raw)
In-Reply-To: <20080622203530.GB4050@solarflare.com>
On Sun, Jun 22, 2008 at 09:35:32PM +0100, Ben Hutchings wrote:
> Ben Dooks wrote:
> > From: Laurent Pinchart <laurentp@cse-semaphore.com>
> >
> > The dm9000 driver accepts either 2 or 3 resources to describe the platform
> > devices. The 2 resources case abuses the ioresource mechanism by passing
> > ioremap()ed memory through the platform device resources. This patch removes
> > converts boards that were using it to the 3 resources scheme.
> [...]
>
> This needs to be applied before the previous patch, otherwise there's
> a point where these boards are broken.
There may be a small overlap, but I'd much rather fix the abuse than
actually leave it in there much longer. The fixup patch has been cc'd
to the blackfin maintainer, so any breakage will be minimal (and will
also be clearly marked, it isn't as if the driver will just fail to
work; there is a clear error being printed and it will gracefully
exit).
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-06-23 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 20:16 [patch v2 00/11] DM9000 patch series for next kernel Ben Dooks
2008-06-22 20:16 ` [patch v2 01/11] DM9000: Remove the 2 resources probe scheme Ben Dooks
2008-06-22 20:34 ` Ben Hutchings
2008-06-22 21:18 ` Ben Dooks
2008-06-23 7:40 ` Laurent Pinchart
2008-06-22 20:16 ` [patch v2 02/11] DM9000: Fixup blackfin after removing 2 resource usage Ben Dooks
2008-06-22 20:35 ` Ben Hutchings
2008-06-23 9:24 ` Ben Dooks [this message]
2008-06-23 9:56 ` Bryan Wu
2008-06-23 10:20 ` Ben Dooks
2008-06-24 2:00 ` Bryan Wu
2008-06-22 20:16 ` [patch v2 03/11] DM9000: Add support for DM9000A and DM9000B chips Ben Dooks
2008-06-22 20:16 ` [patch v2 04/11] DM9000: Cleanup source code Ben Dooks
2008-06-22 20:16 ` [patch v2 05/11] DM9000: Cleanup source code - remove forward declerations Ben Dooks
2008-06-22 20:16 ` [patch v2 06/11] DM9000: Use NSR to determine link-status on internal PHY Ben Dooks
2008-06-22 20:16 ` [patch v2 07/11] DM9000: Allow the use of the NSR register to get link status Ben Dooks
2008-06-22 20:16 ` [patch v2 08/11] DM9000: Add missing msleep() in EEPROM wait code Ben Dooks
2008-06-22 20:16 ` [patch v2 09/11] DM9000: Re-unit menuconfig entries for DM9000 driver Ben Dooks
2008-06-22 20:16 ` [patch v2 10/11] DM9000: Show Mbps on link change if using simple polling Ben Dooks
2008-06-22 20:16 ` [patch v2 11/11] DM9000: Remove DEFAULT_TRIGGER for request_irq() flags Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623092407.GD26276@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=bhutchings@solarflare.com \
--cc=cooloney@kernel.org \
--cc=jeff@garzik.org \
--cc=laurentp@cse-semaphore.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).