From: Jarek Poplawski <jarkao2@gmail.com>
To: Octavian Purdila <opurdila@ixiacom.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO
Date: Mon, 23 Jun 2008 22:48:40 +0200 [thread overview]
Message-ID: <20080623204840.GB2462@ami.dom.local> (raw)
In-Reply-To: <200806231250.31087.opurdila@ixiacom.com>
On Mon, Jun 23, 2008 at 12:50:30PM +0300, Octavian Purdila wrote:
> On Monday 23 June 2008, Jarek Poplawski wrote:
...
> > But, I think it's better to separate the change of functionality (a
> > recursive processing of frag_list) to another patch (if there is a
> > practical reason for this).
> >
>
> Yes, it makes sense, I'll remove the recursion from this patch.
>
> About the recursion: don't know if it makes a difference from a functional
> perspective (I don't think that we can have frag_lists in frag_lists), but
> I've noticed that skb_copy_bits does recurse. Any idea why?
I meant it's potentially the change of functionality in this place.
Probably this recursion is intended for 1 level only, and is natural
in this place. But, since this place didn't use this, it should be
safer to separate this change to another patch (of course, consistency
with skb_copy_bits could be a good argument).
Jarek P.
next prev parent reply other threads:[~2008-06-23 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <485B4ADE.8070102@domat.com.pl>
2008-06-18 16:07 ` [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO Octavian Purdila
2008-06-20 6:37 ` Jarek Poplawski
2008-06-20 10:09 ` Octavian Purdila
2008-06-20 11:01 ` Jarek Poplawski
2008-06-20 12:39 ` Octavian Purdila
2008-06-20 13:01 ` Jarek Poplawski
2008-06-20 20:44 ` Octavian Purdila
2008-06-22 21:07 ` Jarek Poplawski
2008-06-23 9:50 ` Octavian Purdila
2008-06-23 20:48 ` Jarek Poplawski [this message]
2008-06-20 21:57 ` Jarek Poplawski
2008-06-21 0:40 ` Octavian Purdila
2008-06-21 8:39 ` Jarek Poplawski
2008-06-21 10:32 ` Octavian Purdila
2008-06-28 0:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623204840.GB2462@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).