From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: Jie.Yang@Atheros.com, jeff@garzik.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
Date: Wed, 25 Jun 2008 22:55:50 -0700 (PDT) [thread overview]
Message-ID: <20080625.225550.199765051.davem@davemloft.net> (raw)
In-Reply-To: <20080625224829.3c6f4789@extreme>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 25 Jun 2008 22:48:29 -0700
> I would prefer that the driver be NAPI only, because configuration
> choices are hard for users and distribution to make correct
> choice. Plus it means two choices for your QA to test.
I agree with Stephen.
It's absolutely to provide a non-NAPI option, please just remove
the option and the conditionals from the code.
next prev parent reply other threads:[~2008-06-26 5:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 5:37 [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-06-26 5:48 ` Stephen Hemminger
2008-06-26 5:55 ` David Miller [this message]
2008-06-26 5:59 ` Willy Tarreau
2008-06-26 6:25 ` Jie Yang
2008-06-27 2:45 ` Jay Cliburn
2008-06-27 5:24 ` Jie Yang
2008-06-27 5:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625.225550.199765051.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jie.Yang@Atheros.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).