From: Stephen Hemminger <shemminger@vyatta.com>
To: Jie Yang <Jie.Yang@Atheros.com>
Cc: "jeff@garzik.org" <jeff@garzik.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2.6.25.3 5/5] atl1e: Atheros L1E Gigabit Ethernet driver
Date: Wed, 25 Jun 2008 22:46:11 -0700 [thread overview]
Message-ID: <20080625224611.49022dba@extreme> (raw)
In-Reply-To: <72981EBCFD196144B7C6999B9FC34A9A3EE603B868@SHEXMB-01.global.atheros.com>
On Thu, 26 Jun 2008 13:38:17 +0800
Jie Yang <Jie.Yang@Atheros.com> wrote:
> From: Jie Yang <jie.yang@atheros.com>
>
> Full patch for the Atheros L1E Gigabit Ethernet driver.
> Supportring AR8121, AR8113 and AR8114
>
> Signed-off-by: Jie Yang <jie.yang @atheros.com>
> +#define AT_MII_LOCK(_adapter) \
> + do { \
> + spin_lock(&(_adapter)->mdio_lock); \
> + } while (0)
> +
> +#define AT_MII_UNLOCK(_adapter) \
> + do { \
> + spin_unlock(&(_adapter)->mdio_lock); \
> + } while (0)
> +
> +#define AT_MII_LOCK_IRQSAVE(_adapter, _flags) \
> + do { \
> + spin_lock_irqsave(&(_adapter)->mdio_lock, (_flags)); \
> + } while (0)
> +
> +#define AT_MII_UNLOCK_IRQRESTORE(_adapter, _flags) \
> + do { \
> + spin_unlock_irqrestore(&(_adapter)->mdio_lock, (_flags));\
> + } while (0)
> +
Please don't obfuscate (ie wrap) locking primitives. It makes it harder
for humans to evaluate the locking.
next prev parent reply other threads:[~2008-06-26 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 5:38 [PATCH 2.6.25.3 5/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-06-26 5:46 ` Stephen Hemminger [this message]
2008-06-28 2:00 ` Jay Cliburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625224611.49022dba@extreme \
--to=shemminger@vyatta.com \
--cc=Jie.Yang@Atheros.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).