* [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
@ 2008-06-26 5:37 Jie Yang
2008-06-26 5:48 ` Stephen Hemminger
2008-06-27 2:45 ` Jay Cliburn
0 siblings, 2 replies; 8+ messages in thread
From: Jie Yang @ 2008-06-26 5:37 UTC (permalink / raw)
To: jeff@garzik.org; +Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
From: Jie Yang <jie.yang@atheros.com>
Full patch for the Atheros L1E Gigabit Ethernet driver.
Supportring AR8121, AR8113 and AR8114
Signed-off-by: Jie Yang <jie.yang @atheros.com>
---
diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/drivers/net/atl1e/Makefile linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile
--- linux-2.6.25.3.orig/drivers/net/atl1e/Makefile 1970-01-01 08:00:00.000000000 +0800
+++ linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile 2008-06-20 11:22:34.000000000 +0800
@@ -0,0 +1,2 @@
+obj-$(CONFIG_ATL1E) += atl1e.o
+atl1e-y += atl1e_main.o atl1e_hw.o atl1e_ethtool.o atl1e_param.o
diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/drivers/net/Kconfig linux-2.6.25.3.atheros/drivers/net/Kconfig
--- linux-2.6.25.3.orig/drivers/net/Kconfig 2008-05-10 12:48:50.000000000 +0800
+++ linux-2.6.25.3.atheros/drivers/net/Kconfig 2008-06-19 18:17:42.000000000 +0800
@@ -2445,6 +2445,32 @@ config ATL1
To compile this driver as a module, choose M here. The module
will be called atl1.
+config ATL1E
+ tristate "Atheros L1e Gigabit Ethernet support (EXPERIMENTAL)"
+ depends on PCI && EXPERIMENTAL
+ select CRC32
+ select MII
+ help
+ This driver supports the Atheros L1E gigabit ethernet adapter.
+
+ To compile this driver as a module, choose M here. The module
+ will be called atl1e.
+
+config ATL1E_NAPI
+ bool "Use Rx Polling (NAPI)"
+ depends on ATL1E
+ help
+ NAPI is a new driver API designed to reduce CPU and interrupt load
+ when the driver is receiving lots of packets from the card. It is
+ still somewhat experimental and thus not yet enabled by default.
+
+ If your estimated Rx load is 10kpps or more, or if the card will be
+ deployed on potentially unfriendly networks (e.g. in a firewall),
+ then say Y here.
+
+ If in doubt, say N.
+
+
endif # NETDEV_1000
#
diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/drivers/net/Makefile linux-2.6.25.3.atheros/drivers/net/Makefile
--- linux-2.6.25.3.orig/drivers/net/Makefile 2008-05-10 12:48:50.000000000 +0800
+++ linux-2.6.25.3.atheros/drivers/net/Makefile 2008-06-20 09:48:38.000000000 +0800
@@ -16,6 +16,7 @@ obj-$(CONFIG_EHEA) += ehea/
obj-$(CONFIG_CAN) += can/
obj-$(CONFIG_BONDING) += bonding/
obj-$(CONFIG_ATL1) += atl1/
+obj-$(CONFIG_ATL1E) += atl1e/
obj-$(CONFIG_GIANFAR) += gianfar_driver.o
obj-$(CONFIG_TEHUTI) += tehuti.o
diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/include/linux/pci_ids.h linux-2.6.25.3.atheros/include/linux/pci_ids.h
--- linux-2.6.25.3.orig/include/linux/pci_ids.h 2008-05-10 12:48:50.000000000 +0800
+++ linux-2.6.25.3.atheros/include/linux/pci_ids.h 2008-06-20 09:43:40.000000000 +0800
@@ -2175,6 +2175,7 @@
#define PCI_VENDOR_ID_ATTANSIC 0x1969
#define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
+#define PCI_DEVICE_ID_ATTANSIC_L1E 0x1026
#define PCI_VENDOR_ID_JMICRON 0x197B
#define PCI_DEVICE_ID_JMICRON_JMB360 0x2360
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-26 5:37 [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
@ 2008-06-26 5:48 ` Stephen Hemminger
2008-06-26 5:55 ` David Miller
2008-06-27 2:45 ` Jay Cliburn
1 sibling, 1 reply; 8+ messages in thread
From: Stephen Hemminger @ 2008-06-26 5:48 UTC (permalink / raw)
To: Jie Yang
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
On Thu, 26 Jun 2008 13:37:23 +0800
Jie Yang <Jie.Yang@Atheros.com> wrote:
> From: Jie Yang <jie.yang@atheros.com>
>
> Full patch for the Atheros L1E Gigabit Ethernet driver.
> Supportring AR8121, AR8113 and AR8114
>
> Signed-off-by: Jie Yang <jie.yang @atheros.com>
> ---
> diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/drivers/net/atl1e/Makefile linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile
> --- linux-2.6.25.3.orig/drivers/net/atl1e/Makefile 1970-01-01 08:00:00.000000000 +0800
> +++ linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile 2008-06-20 11:22:34.000000000 +0800
> @@ -0,0 +1,2 @@
> +obj-$(CONFIG_ATL1E) += atl1e.o
> +atl1e-y += atl1e_main.o atl1e_hw.o atl1e_ethtool.o atl1e_param.o
> diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff linux-2.6.25.3.orig/drivers/net/Kconfig linux-2.6.25.3.atheros/drivers/net/Kconfig
> --- linux-2.6.25.3.orig/drivers/net/Kconfig 2008-05-10 12:48:50.000000000 +0800
> +++ linux-2.6.25.3.atheros/drivers/net/Kconfig 2008-06-19 18:17:42.000000000 +0800
> @@ -2445,6 +2445,32 @@ config ATL1
> To compile this driver as a module, choose M here. The module
> will be called atl1.
>
> +config ATL1E
> + tristate "Atheros L1e Gigabit Ethernet support (EXPERIMENTAL)"
> + depends on PCI && EXPERIMENTAL
> + select CRC32
> + select MII
> + help
> + This driver supports the Atheros L1E gigabit ethernet adapter.
> +
> + To compile this driver as a module, choose M here. The module
> + will be called atl1e.
> +
> +config ATL1E_NAPI
> + bool "Use Rx Polling (NAPI)"
> + depends on ATL1E
> + help
> + NAPI is a new driver API designed to reduce CPU and interrupt load
> + when the driver is receiving lots of packets from the card. It is
> + still somewhat experimental and thus not yet enabled by default.
> +
> + If your estimated Rx load is 10kpps or more, or if the card will be
> + deployed on potentially unfriendly networks (e.g. in a firewall),
> + then say Y here.
> +
> + If in doubt, say N.
> +
> +
> endif # NETDEV_1000
Congratulations on the best new vendor driver submission to date.
I would prefer that the driver be NAPI only, because configuration choices
are hard for users and distribution to make correct choice. Plus it means two
choices for your QA to test.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-26 5:48 ` Stephen Hemminger
@ 2008-06-26 5:55 ` David Miller
2008-06-26 5:59 ` Willy Tarreau
0 siblings, 1 reply; 8+ messages in thread
From: David Miller @ 2008-06-26 5:55 UTC (permalink / raw)
To: shemminger; +Cc: Jie.Yang, jeff, linux-kernel, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 25 Jun 2008 22:48:29 -0700
> I would prefer that the driver be NAPI only, because configuration
> choices are hard for users and distribution to make correct
> choice. Plus it means two choices for your QA to test.
I agree with Stephen.
It's absolutely to provide a non-NAPI option, please just remove
the option and the conditionals from the code.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-26 5:55 ` David Miller
@ 2008-06-26 5:59 ` Willy Tarreau
2008-06-26 6:25 ` Jie Yang
0 siblings, 1 reply; 8+ messages in thread
From: Willy Tarreau @ 2008-06-26 5:59 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, Jie.Yang, jeff, linux-kernel, netdev
On Wed, Jun 25, 2008 at 10:55:50PM -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 25 Jun 2008 22:48:29 -0700
>
> > I would prefer that the driver be NAPI only, because configuration
> > choices are hard for users and distribution to make correct
> > choice. Plus it means two choices for your QA to test.
>
> I agree with Stephen.
>
> It's absolutely to provide a non-NAPI option, please just remove
> the option and the conditionals from the code.
Also I think it's useless to provide one patch per source file. It'd
be better to have one whole patch, or several ones if some features
may be added incrementally.
Willy
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-26 5:59 ` Willy Tarreau
@ 2008-06-26 6:25 ` Jie Yang
0 siblings, 0 replies; 8+ messages in thread
From: Jie Yang @ 2008-06-26 6:25 UTC (permalink / raw)
To: Willy Tarreau, David Miller
Cc: shemminger@vyatta.com, jeff@garzik.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
From: Willy Tarreau [w@1wt.eu]
Date: Thursday, June 26, 2008 1:59 PM
> On Wed, Jun 25, 2008 at 10:55:50PM -0700, David Miller wrote:
> > From: Stephen Hemminger <shemminger@vyatta.com>
> > Date: Wed, 25 Jun 2008 22:48:29 -0700
> >
> > > I would prefer that the driver be NAPI only, because
> configuration
> > > choices are hard for users and distribution to make
> correct choice.
> > > Plus it means two choices for your QA to test.
> >
> > I agree with Stephen.
> >
> > It's absolutely to provide a non-NAPI option, please just
> remove the
> > option and the conditionals from the code.
>
> Also I think it's useless to provide one patch per source
> file. It'd be better to have one whole patch, or several ones
> if some features may be added incrementally.
>
> Willy
>
>
Ok, thanks for comments. I will change code on these comments.
jie
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-26 5:37 [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-06-26 5:48 ` Stephen Hemminger
@ 2008-06-27 2:45 ` Jay Cliburn
2008-06-27 5:24 ` Jie Yang
1 sibling, 1 reply; 8+ messages in thread
From: Jay Cliburn @ 2008-06-27 2:45 UTC (permalink / raw)
To: Jie Yang
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Patches 1 and 2 reviewed tonight. I intend to review the other 3 in
coming days.
On Thu, 26 Jun 2008 13:37:23 +0800
Jie Yang <Jie.Yang@Atheros.com> wrote:
> From: Jie Yang <jie.yang@atheros.com>
>
> Full patch for the Atheros L1E Gigabit Ethernet driver.
> Supportring AR8121, AR8113 and AR8114
Please generate the patch against current mainline (or at least
current -rc); it fails to apply cleanly as is.
>
> Signed-off-by: Jie Yang <jie.yang @atheros.com>
> ---
> diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff
> linux-2.6.25.3.orig/drivers/net/atl1e/Makefile
> linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile ---
> linux-2.6.25.3.orig/drivers/net/atl1e/Makefile 1970-01-01
> 08:00:00.000000000 +0800 +++
> linux-2.6.25.3.atheros/drivers/net/atl1e/Makefile 2008-06-20
> 11:22:34.000000000 +0800 @@ -0,0 +1,2 @@ +obj-$(CONFIG_ATL1E) +=
> atl1e.o +atl1e-y += atl1e_main.o atl1e_hw.o
> atl1e_ethtool.o atl1e_param.o diff -uprN -X
Use tabs, not spaces, for indentation. Run scripts/checkpatch.pl on
each patchfile and try to eliminate as many errors as you can. There
are hundreds of checkpatch-reported errors in your submitted patches.
> linux-2.6.25.3.orig/Documentation/dontdiff
> linux-2.6.25.3.orig/drivers/net/Kconfig
> linux-2.6.25.3.atheros/drivers/net/Kconfig ---
> linux-2.6.25.3.orig/drivers/net/Kconfig 2008-05-10
> 12:48:50.000000000 +0800 +++
> linux-2.6.25.3.atheros/drivers/net/Kconfig 2008-06-19
> 18:17:42.000000000 +0800 @@ -2445,6 +2445,32 @@ config ATL1 To
> compile this driver as a module, choose M here. The module will be
> called atl1.
>
> +config ATL1E
> + tristate "Atheros L1e Gigabit Ethernet support (EXPERIMENTAL)"
> + depends on PCI && EXPERIMENTAL
> + select CRC32
> + select MII
> + help
> + This driver supports the Atheros L1E gigabit ethernet
> adapter. +
> + To compile this driver as a module, choose M here. The
> module
> + will be called atl1e.
> +
> +config ATL1E_NAPI
> + bool "Use Rx Polling (NAPI)"
> + depends on ATL1E
> + help
> + NAPI is a new driver API designed to reduce CPU and
> interrupt load
> + when the driver is receiving lots of packets from the card.
> It is
> + still somewhat experimental and thus not yet enabled by
> default. +
> + If your estimated Rx load is 10kpps or more, or if the card
> will be
> + deployed on potentially unfriendly networks (e.g. in a
> firewall),
> + then say Y here.
> +
> + If in doubt, say N.
> +
> +
Remove extra blank line.
> endif # NETDEV_1000
>
> #
> diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff
> linux-2.6.25.3.orig/drivers/net/Makefile
> linux-2.6.25.3.atheros/drivers/net/Makefile ---
> linux-2.6.25.3.orig/drivers/net/Makefile 2008-05-10
> 12:48:50.000000000 +0800 +++
> linux-2.6.25.3.atheros/drivers/net/Makefile 2008-06-20
> 09:48:38.000000000 +0800 @@ -16,6 +16,7 @@ obj-$(CONFIG_EHEA) +=
> ehea/ obj-$(CONFIG_CAN) += can/ obj-$(CONFIG_BONDING) += bonding/
> obj-$(CONFIG_ATL1) += atl1/ +obj-$(CONFIG_ATL1E) += atl1e/
> obj-$(CONFIG_GIANFAR) += gianfar_driver.o obj-$(CONFIG_TEHUTI) +=
> tehuti.o
>
> diff -uprN -X linux-2.6.25.3.orig/Documentation/dontdiff
> linux-2.6.25.3.orig/include/linux/pci_ids.h
> linux-2.6.25.3.atheros/include/linux/pci_ids.h ---
> linux-2.6.25.3.orig/include/linux/pci_ids.h 2008-05-10
> 12:48:50.000000000 +0800 +++
> linux-2.6.25.3.atheros/include/linux/pci_ids.h 2008-06-20
> 09:43:40.000000000 +0800 @@ -2175,6 +2175,7 @@
>
> #define PCI_VENDOR_ID_ATTANSIC 0x1969
> #define PCI_DEVICE_ID_ATTANSIC_L1 0x1048
> +#define PCI_DEVICE_ID_ATTANSIC_L1E 0x1026
>
> #define PCI_VENDOR_ID_JMICRON 0x197B
> #define PCI_DEVICE_ID_JMICRON_JMB360 0x2360
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-27 2:45 ` Jay Cliburn
@ 2008-06-27 5:24 ` Jie Yang
2008-06-27 5:35 ` Jeff Garzik
0 siblings, 1 reply; 8+ messages in thread
From: Jie Yang @ 2008-06-27 5:24 UTC (permalink / raw)
To: Jay Cliburn
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
From: Jay Cliburn [acliburn@bellsouth.net]
Date: Friday, June 27, 2008 10:45 AM
> Patches 1 and 2 reviewed tonight. I intend to review the
> other 3 in coming days.
Thanks for your help.
I will update source code on these comments.
> On Thu, 26 Jun 2008 13:37:23 +0800
> Jie Yang <Jie.Yang@Atheros.com> wrote:
>
> > From: Jie Yang <jie.yang@atheros.com>
> >
> > Full patch for the Atheros L1E Gigabit Ethernet driver.
> > Supportring AR8121, AR8113 and AR8114
>
> Please generate the patch against current mainline (or at
> least current -rc); it fails to apply cleanly as is.
>
how about use the git
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Best wishes
jie
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
2008-06-27 5:24 ` Jie Yang
@ 2008-06-27 5:35 ` Jeff Garzik
0 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2008-06-27 5:35 UTC (permalink / raw)
To: Jie Yang
Cc: Jay Cliburn, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Jie Yang wrote:
> From: Jay Cliburn [acliburn@bellsouth.net]
> Date: Friday, June 27, 2008 10:45 AM
>
>> Patches 1 and 2 reviewed tonight. I intend to review the
>> other 3 in coming days.
>
> Thanks for your help.
> I will update source code on these comments.
>
>> On Thu, 26 Jun 2008 13:37:23 +0800
>> Jie Yang <Jie.Yang@Atheros.com> wrote:
>>
>>> From: Jie Yang <jie.yang@atheros.com>
>>>
>>> Full patch for the Atheros L1E Gigabit Ethernet driver.
>>> Supportring AR8121, AR8113 and AR8114
>> Please generate the patch against current mainline (or at
>> least current -rc); it fails to apply cleanly as is.
>>
>
> how about use the git
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
You'll want to use
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6.git
Regards,
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2008-06-27 5:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-26 5:37 [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-06-26 5:48 ` Stephen Hemminger
2008-06-26 5:55 ` David Miller
2008-06-26 5:59 ` Willy Tarreau
2008-06-26 6:25 ` Jie Yang
2008-06-27 2:45 ` Jay Cliburn
2008-06-27 5:24 ` Jie Yang
2008-06-27 5:35 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).