From: Willy Tarreau <w@1wt.eu>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, Jie.Yang@Atheros.com, jeff@garzik.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
Date: Thu, 26 Jun 2008 07:59:07 +0200 [thread overview]
Message-ID: <20080626055907.GD1369@1wt.eu> (raw)
In-Reply-To: <20080625.225550.199765051.davem@davemloft.net>
On Wed, Jun 25, 2008 at 10:55:50PM -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 25 Jun 2008 22:48:29 -0700
>
> > I would prefer that the driver be NAPI only, because configuration
> > choices are hard for users and distribution to make correct
> > choice. Plus it means two choices for your QA to test.
>
> I agree with Stephen.
>
> It's absolutely to provide a non-NAPI option, please just remove
> the option and the conditionals from the code.
Also I think it's useless to provide one patch per source file. It'd
be better to have one whole patch, or several ones if some features
may be added incrementally.
Willy
next prev parent reply other threads:[~2008-06-26 5:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 5:37 [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver Jie Yang
2008-06-26 5:48 ` Stephen Hemminger
2008-06-26 5:55 ` David Miller
2008-06-26 5:59 ` Willy Tarreau [this message]
2008-06-26 6:25 ` Jie Yang
2008-06-27 2:45 ` Jay Cliburn
2008-06-27 5:24 ` Jie Yang
2008-06-27 5:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080626055907.GD1369@1wt.eu \
--to=w@1wt.eu \
--cc=Jie.Yang@Atheros.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).