From: David Miller <davem@davemloft.net>
To: eli@dev.mellanox.co.il
Cc: netdev@vger.kernel.org, THEMANN@de.ibm.com,
general@lists.openfabrics.org, or.gerlitz@gmail.com,
vlad@mellanox.co.il, rdreier@cisco.com
Subject: Re: [PATCH v2] net/inet_lro: remove setting skb->ip_summed when not LRO-able
Date: Fri, 27 Jun 2008 20:09:14 -0700 (PDT) [thread overview]
Message-ID: <20080627.200914.146689237.davem@davemloft.net> (raw)
In-Reply-To: <1214407752.23583.69.camel@mtls03>
From: Eli Cohen <eli@dev.mellanox.co.il>
Date: Wed, 25 Jun 2008 18:29:12 +0300
> When an SKB cannot be chained to a session, the current code attempts
> to "restore" its ip_summed field from lro_mgr->ip_summed. However,
> lro_mgr->ip_summed does not hold the original value; in fact, we'd
> better not touch skb->ip_summed since it is not modified by the code
> in the path leading to a failure to chain it.
> Also use a cleaer comment to the describe the ip_summed field of
> struct net_lro_mgr.
>
> Issue raised by Or Gerlitz <ogerlitz@voltaire.com>
>
> Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Patch applied, thanks everyone.
prev parent reply other threads:[~2008-06-28 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 15:29 [PATCH v2] net/inet_lro: remove setting skb->ip_summed when not LRO-able Eli Cohen
2008-06-28 3:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627.200914.146689237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=THEMANN@de.ibm.com \
--cc=eli@dev.mellanox.co.il \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=rdreier@cisco.com \
--cc=vlad@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).