From: Thomas Graf <tgraf@suug.ch>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: em_cmp.c use unaligned access helpers
Date: Mon, 30 Jun 2008 01:26:39 +0200 [thread overview]
Message-ID: <20080629232638.GO20815@postel.suug.ch> (raw)
In-Reply-To: <1214762490.6037.9.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> 2008-06-29 11:01
> OK, but be16/32_to_cpu is a no-op on be-arches, so there is a bug here on
> big-endian machines as they won't switch it back, your simplified patch
> is actually a bugfix in that case.
I noticed that my change wouldn't be correct. The point is to allow
userspace to convert the filter values to big endian once, supply them
to the kernel and compare big endian values directly. The be16/32_to_cpu
convertion is available to support greater-than/lesser-than on little
endian architectures.
next prev parent reply other threads:[~2008-06-29 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 21:14 [PATCH] net: em_cmp.c use unaligned access helpers Harvey Harrison
2008-06-28 3:16 ` David Miller
2008-06-29 9:54 ` Thomas Graf
2008-06-29 9:55 ` Thomas Graf
2008-06-29 23:20 ` Harvey Harrison
2008-06-29 18:01 ` Harvey Harrison
2008-06-29 23:26 ` Thomas Graf [this message]
2008-07-05 2:10 ` Harvey Harrison
2008-07-10 11:13 ` Thomas Graf
-- strict thread matches above, loose matches on Subject: below --
2008-09-18 0:00 Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629232638.GO20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).