From: Eli Cohen <eli@dev.mellanox.co.il>
To: Or Gerlitz <ogerlitz@voltaire.com>
Cc: netdev@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
general-list <general@lists.openfabrics.org>
Subject: Re: [ofa-general] [PATCH] IB/IPoIB: Fix change mtu when switching to UD mode
Date: Tue, 1 Jul 2008 16:45:56 +0300 [thread overview]
Message-ID: <20080701134556.GD14384@mtls03> (raw)
In-Reply-To: <20080701134229.GC14384@mtls03>
On Tue, Jul 01, 2008 at 04:42:29PM +0300, Eli Cohen wrote:
>
> I see, though I would expect to see a comment stating this requirement
> both at the documentation of call_netdevice_notifiers() and that of
> dev_set_mtu() and any other exported functions that requires this kind
> of locking.
> Moreover, in this specific case, it appears that it is not required to
> take the rtlnl lock -- if it would be a must, I would have experienced
> a dump_stack() due to
>
> ASSERT_RTNL();
>
> in bond_alb_handle_active_change().
Or some other function registered for notifications.
>
>
> The fact that I did not hit such an assert does not mean I may avoid
> taking the rtnl lock but it appears to me that the issue is not well
> undrestood.
> _______________________________________________
> general mailing list
> general@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
prev parent reply other threads:[~2008-07-01 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080630160651.GA6024@mtls03>
[not found] ` <4869CE9C.2050408@voltaire.com>
[not found] ` <20080701071559.GE6024@mtls03>
[not found] ` <486A1CB1.1020904@voltaire.com>
2008-07-01 13:42 ` [ofa-general] [PATCH] IB/IPoIB: Fix change mtu when switching to UD mode Eli Cohen
2008-07-01 13:45 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701134556.GD14384@mtls03 \
--to=eli@dev.mellanox.co.il \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).