netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 2/3] ipv4: fix sysctl documentation of time related values
Date: Tue, 1 Jul 2008 15:39:26 -0700	[thread overview]
Message-ID: <20080701153926.7b3fe1dd@extreme> (raw)
In-Reply-To: <20080701153820.235faa72@extreme>

These sysctl values are time related and all use the same routine
(proc_dointvec_jiffies) that internally converts from seconds to jiffies.
The code is fine, the documentation is just wrong.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/Documentation/networking/ip-sysctl.txt	2008-07-01 14:45:30.000000000 -0700
+++ b/Documentation/networking/ip-sysctl.txt	2008-07-01 14:45:56.000000000 -0700
@@ -81,23 +81,23 @@ inet_peer_minttl - INTEGER
 	Minimum time-to-live of entries.  Should be enough to cover fragment
 	time-to-live on the reassembling side.  This minimum time-to-live  is
 	guaranteed if the pool size is less than inet_peer_threshold.
-	Measured in jiffies(1).
+	Measured in seconds.
 
 inet_peer_maxttl - INTEGER
 	Maximum time-to-live of entries.  Unused entries will expire after
 	this period of time if there is no memory pressure on the pool (i.e.
 	when the number of entries in the pool is very small).
-	Measured in jiffies(1).
+	Measured in seconds.
 
 inet_peer_gc_mintime - INTEGER
 	Minimum interval between garbage collection passes.  This interval is
 	in effect under high memory pressure on the pool.
-	Measured in jiffies(1).
+	Measured in seconds.
 
 inet_peer_gc_maxtime - INTEGER
 	Minimum interval between garbage collection passes.  This interval is
 	in effect under low (or absent) memory pressure on the pool.
-	Measured in jiffies(1).
+	Measured in seconds.
 
 TCP variables: 
 
@@ -795,10 +795,6 @@ tag - INTEGER
 	Allows you to write a number, which can be used as required.
 	Default value is 0.
 
-(1) Jiffie: internal timeunit for the kernel. On the i386 1/100s, on the
-Alpha 1/1024s. See the HZ define in /usr/include/asm/param.h for the exact
-value on your system. 
-
 Alexey Kuznetsov.
 kuznet@ms2.inr.ac.ru
 

  reply	other threads:[~2008-07-01 22:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 22:38 [PATCH 1/3] icmp: fix units for ratelimit Stephen Hemminger
2008-07-01 22:39 ` Stephen Hemminger [this message]
2008-07-01 22:43   ` [PATCH 3/3] ip: sysctl documentation cleanup Stephen Hemminger
2008-07-01 22:55     ` Randy.Dunlap
2008-07-01 23:13       ` Stephen Hemminger
2008-07-01 23:26         ` Karen Shaeffer
2008-07-01 23:32           ` Randy.Dunlap
2008-07-02  2:28         ` David Miller
2008-07-10 21:39           ` Stephen Hemminger
2008-07-10 21:44             ` Randy Dunlap
2008-07-10 23:51               ` David Miller
2008-07-02  0:23   ` [PATCH 2/3] ipv4: fix sysctl documentation of time related values David Miller
2008-07-02  2:29 ` [PATCH 1/3] icmp: fix units for ratelimit David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080701153926.7b3fe1dd@extreme \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).