From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: vinay@linux.vnet.ibm.com, krkumar2@in.ibm.com,
mchan@broadcom.com, Matheos.Worku@Sun.COM,
linux-wireless@vger.kernel.org
Subject: [PATCH 13/39]: pkt_sched: Add qdisc_all_tx_empty()
Date: Thu, 03 Jul 2008 00:03:43 -0700 (PDT) [thread overview]
Message-ID: <20080703.000343.16709755.davem@davemloft.net> (raw)
As per comments, this isn't a foolproof implementation. This is being
added so that we can contain and isolate all the explicit ->tx_queue
references in the tree.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/net/irda/irda_device.h | 2 +-
include/net/sch_generic.h | 13 +++++++++++++
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/include/net/irda/irda_device.h b/include/net/irda/irda_device.h
index 16fbf67..3025ae1 100644
--- a/include/net/irda/irda_device.h
+++ b/include/net/irda/irda_device.h
@@ -223,7 +223,7 @@ int irda_device_is_receiving(struct net_device *dev);
/* Interface for internal use */
static inline int irda_device_txqueue_empty(const struct net_device *dev)
{
- return skb_queue_empty(&dev->tx_queue.qdisc->q);
+ return qdisc_all_tx_empty(dev);
}
int irda_device_set_raw_mode(struct net_device* self, int status);
struct net_device *alloc_irdadev(int sizeof_priv);
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index a71994b..f83e860 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -191,6 +191,19 @@ static inline void qdisc_reset_all_tx(struct net_device *dev)
qdisc_reset(dev->tx_queue.qdisc);
}
+/* Are all TX queues of the device empty? */
+static inline bool qdisc_all_tx_empty(const struct net_device *dev)
+{
+ struct netdev_queue *txq = &dev->tx_queue;
+
+ /* XXX This is not correct but it is good enough for the
+ * XXX one place that wants this, IRDA. If we wanted to
+ * XXX do this right, we'd need to add a qdisc op to
+ * XXX probe for the queue state.
+ */
+ return skb_queue_empty(&txq->qdisc->q);
+}
+
static inline int __qdisc_enqueue_tail(struct sk_buff *skb, struct Qdisc *sch,
struct sk_buff_head *list)
{
--
1.5.6
next reply other threads:[~2008-07-03 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 7:03 David Miller [this message]
[not found] ` <20080703.000343.16709755.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-03 13:11 ` [PATCH 13/39]: pkt_sched: Add qdisc_all_tx_empty() Patrick McHardy
[not found] ` <486CCFFE.7060009-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-03 20:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703.000343.16709755.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=krkumar2@in.ibm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vinay@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).