From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
kaber@trash.net, netdev@vger.kernel.org,
klassert@mathematik.tu-chemnitz.de
Subject: Re: [PATCH] xfrm: Fix inter family IPsec tunnel handling again
Date: Thu, 3 Jul 2008 11:18:36 +0200 [thread overview]
Message-ID: <20080703091836.GK9549@secunet.com> (raw)
In-Reply-To: <20080703090522.GB27923@gondor.apana.org.au>
On Thu, Jul 03, 2008 at 05:05:22PM +0800, Herbert Xu wrote:
> On Thu, Jul 03, 2008 at 10:55:42AM +0200, Steffen Klassert wrote:
> >
> > +#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
> > + case IPPROTO_IPV6:
> > + if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))
> > + goto out;
> > + break;
> > +#endif
>
> This is supposed to use protocol-agnostic data so why do you need
> the ifdef?
>
Well, I added the ifdef because it was there in the 2.6.24 code,
I could remove it and resend if you agree with the rest of the patch.
Steffen
next prev parent reply other threads:[~2008-07-03 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 8:55 [PATCH] xfrm: Fix inter family IPsec tunnel handling again Steffen Klassert
2008-07-03 9:05 ` Herbert Xu
2008-07-03 9:18 ` Steffen Klassert [this message]
2008-07-03 9:53 ` Herbert Xu
2008-07-03 11:22 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703091836.GK9549@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).