From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Adam Langley <agl@imperialviolet.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs
Date: Fri, 4 Jul 2008 12:24:03 +0400 [thread overview]
Message-ID: <20080704082402.GA16259@2ka.mipt.ru> (raw)
In-Reply-To: <396556a20805301217k293e5718h6bbf02bfe069000@europa>
Hi.
On Thu, Jul 03, 2008 at 05:19:41PM -0700, Adam Langley (agl@imperialviolet.org) wrote:
> +int tcp_md5_hash_key(struct tcp_md5sig_pool *hp, struct tcp_md5sig_key *key)
> +{
> + struct scatterlist sg;
> +
> + sg_init_table(&sg, 1);
> + sg_set_buf(&sg, key->key, key->keylen);
> + return crypto_hash_update(&hp->md5_desc, &sg, key->keylen);
> +}
A trivial nit: you can use sg_init_one() to initialize single
scatterlist and set data pointer instead of sg_init_table()/sg_set_buf()
in all places where you use single sg.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-07-04 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 0:19 [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs Adam Langley
2008-07-04 4:05 ` Stephen Hemminger
2008-07-04 8:24 ` Evgeniy Polyakov [this message]
2008-07-07 17:21 ` Adam Langley
2008-07-07 17:22 ` Adam Langley
2008-07-07 18:22 ` Stephen Hemminger
2008-07-07 21:40 ` Adam Langley
2008-07-07 21:41 ` Adam Langley
2008-07-09 16:58 ` [RFC] mark MD5 as broken in older (stable) kernels Stephen Hemminger
2008-07-09 17:01 ` Adam Langley
2008-07-09 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704082402.GA16259@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=agl@imperialviolet.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).