netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arjan@infradead.org
Cc: wangchen@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message
Date: Sun, 06 Jul 2008 21:49:15 -0700 (PDT)	[thread overview]
Message-ID: <20080706.214915.255106355.davem@davemloft.net> (raw)
In-Reply-To: <20080706213427.406e8f29@infradead.org>

From: Arjan van de Ven <arjan@infradead.org>
Date: Sun, 6 Jul 2008 21:34:27 -0700

> On Sun, 06 Jul 2008 20:59:05 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
> 
> > 
> > Also correct.
> 
> ok updated version below; I also added an explicit comment for the
> ethtool locking
> 
> From: Arjan van de Ven <arjan@linux.intel.com>
> Subject: Use WARN_ONCE() in the netdev timeout handler (and print module name)

I'm basically fine with these changes.

But plain WARN() and WARN_ONCE() are not in any tree I am maintaining
at the moment, so I really can't add it to net-next-2.6 or net-2.6
even if I wanted to.

Do you really need this dependency?

  reply	other threads:[~2008-07-07  4:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-06 20:08 Printing the driver name as part of the netdev watchdog message Arjan van de Ven
2008-07-06 22:53 ` David Miller
2008-07-06 23:56   ` Arjan van de Ven
2008-07-07  1:51     ` Wang Chen
2008-07-07  3:59       ` David Miller
2008-07-07  4:34         ` Arjan van de Ven
2008-07-07  4:49           ` David Miller [this message]
2008-07-07  4:57             ` Arjan van de Ven
2008-07-07  6:44               ` David Miller
2008-07-07 15:23                 ` Arjan van de Ven
2008-07-07  1:08   ` Stephen Hemminger
2008-07-07  1:22     ` David Miller
2008-07-07  1:53       ` Jeff Garzik
2008-07-07 17:05         ` Stephen Hemminger
2008-07-07 22:45       ` Roland Dreier
2008-07-07 22:57         ` David Miller
2008-07-07 23:14           ` Roland Dreier
2008-07-07 23:44             ` Stephen Hemminger
2008-07-08  0:10               ` Arjan van de Ven
2008-07-08 19:13             ` Steve Wise
2008-07-08 21:31               ` David Miller
2008-07-08 21:47                 ` Arjan van de Ven
2008-07-08 21:57                   ` David Miller
2008-07-08 23:48                     ` Arjan van de Ven
2008-07-08 23:53                       ` David Miller
2008-07-09  0:17                         ` Arjan van de Ven
2008-07-09  1:44                         ` Arjan van de Ven
2008-07-09  3:16                           ` Stephen Hemminger
2008-07-09 17:20                             ` Joe Perches
2008-07-09 17:56                               ` Arjan van de Ven
2008-07-09 18:20                                 ` Joe Perches
2008-07-09 18:50                                   ` Arjan van de Ven
2008-07-09 18:28                                 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080706.214915.255106355.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arjan@infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=wangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).