netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: olel@ans.pl
Cc: kaber@trash.net, netdev@vger.kernel.org, greearb@candelatech.com
Subject: Re: Wrong padding of short packets send by a tagged-vlan interface?
Date: Mon, 07 Jul 2008 14:54:31 -0700 (PDT)	[thread overview]
Message-ID: <20080707.145431.149346529.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0807072337320.15459@bizon.gios.gov.pl>

From: Krzysztof Oledzki <olel@ans.pl>
Date: Mon, 7 Jul 2008 23:40:58 +0200 (CEST)

> Not all drivers use skb_padto:
> 
> # grep skb_padto -R e1000 e1000e bnx*.c
> (empty)
> 
> Any idea where to change it in the above ones?

They don't need to, most devices handle this issue
in hardware as far as I understand.

  reply	other threads:[~2008-07-07 21:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 21:01 Wrong padding of short packets send by a tagged-vlan interface? Krzysztof Oledzki
2008-07-07 21:06 ` Patrick McHardy
2008-07-07 21:40   ` Krzysztof Oledzki
2008-07-07 21:54     ` David Miller [this message]
2008-07-07 21:06 ` Ben Greear
2008-07-07 21:12   ` Patrick McHardy
2008-07-07 21:29   ` Krzysztof Oledzki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080707.145431.149346529.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=greearb@candelatech.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=olel@ans.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).