From: Stephen Hemminger <shemminger@vyatta.com>
To: "Adam Langley" <agl@imperialviolet.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs
Date: Mon, 7 Jul 2008 11:22:37 -0700 [thread overview]
Message-ID: <20080707112237.14fb3284@extreme> (raw)
In-Reply-To: <396556a20805301217k293e5718h6bbf02bfe069001@europa>
On Mon, 7 Jul 2008 10:22:43 -0700
"Adam Langley" <agl@imperialviolet.org> wrote:
> ipv[46]: Fix MD5 signatures for non-linear skbs
>
> Currently, the MD5 code assumes that the SKBs are linear and, in the case
> that they aren't, happily goes off and hashes off the end of the SKB and
> into random memory.
>
> Reported by Stephen Hemminger in [1]. Advice thanks to Stephen and Evgeniy
> Polyakov. Also includes a couple of missed route_caps from Stephen's patch
> in [2].
>
> [1] http://marc.info/?l=linux-netdev&m=121445989106145&w=2
> [2] http://marc.info/?l=linux-netdev&m=121459157816964&w=2
>
> Signed-off-by: Adam Langley <agl@imperialviolet.org>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Patch doesn't apply cleanly to net-next-2.6 tree because of other changes
so to help the merge, please create a version for that as well.
next prev parent reply other threads:[~2008-07-07 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 0:19 [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs Adam Langley
2008-07-04 4:05 ` Stephen Hemminger
2008-07-04 8:24 ` Evgeniy Polyakov
2008-07-07 17:21 ` Adam Langley
2008-07-07 17:22 ` Adam Langley
2008-07-07 18:22 ` Stephen Hemminger [this message]
2008-07-07 21:40 ` Adam Langley
2008-07-07 21:41 ` Adam Langley
2008-07-09 16:58 ` [RFC] mark MD5 as broken in older (stable) kernels Stephen Hemminger
2008-07-09 17:01 ` Adam Langley
2008-07-09 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080707112237.14fb3284@extreme \
--to=shemminger@vyatta.com \
--cc=agl@imperialviolet.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).