Re: Printing the driver name as part of the netdev watchdog message

[Arjan van de Ven <arjan@infradead.org>]

On Mon, 7 Jul 2008 16:44:25 -0700
Stephen Hemminger <shemminger@vyatta.com> wrote:

> On Mon, 07 Jul 2008 16:14:31 -0700
> Roland Dreier <rdreier@cisco.com> wrote:
> 
> >  > I doubt it uses the RTNL semaphore elsewhere to protect
> >  > against this path, which is the only protection these
> >  > calls currently have.
> > 
> > As far as I can tell from reading the code, the only places in cxgb3
> > that use t3_read_flash() are in the netdevice's open and ioctl
> > methods, and the ethtool get_drvinfo method.  So as far as I can
> > tell the current code is fine as long as rtnl is held across
> > get_drvinfo.
> > 
> >  > Please don't bring up scarecrows, this looks like simply
> >  > a bug which already exists.
> > 
> > I don't even know how to take this.  "Please don't review our
> > changes"?? "Please don't report bugs"??
> > 
> >  - R.
> 
> Long term, it would be good to move the driver name into device
> struct? Easier and could work for all those random other drivers :-)

well we can already get it from the object model ;)
Dave just preferred to get it from ethtool and only get it from object
model if ethtool didn't work out.. (which makes sense)

I can see the point almost of having a generic_ethtool_getdrv which
just fills the struct from the object model data ;)



-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org