netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: swise@opengridcomputing.com, rdreier@cisco.com,
	shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: Printing the driver name as part of the netdev watchdog message
Date: Tue, 8 Jul 2008 16:48:26 -0700	[thread overview]
Message-ID: <20080708164826.2a2d52c2@infradead.org> (raw)
In-Reply-To: <20080708.145738.12692130.davem@davemloft.net>

On Tue, 08 Jul 2008 14:57:38 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> 
> What we need instead is to cache the info block into the netdev struct
> when the driver is ->open()'d, and then you can fetch it out of
> there however you like.

but.. isn't that like almost the same as using the object model data at
that point?

> 
> Or, at least, that is one possible approach.

I'll look at it; but this begs the question if this shouldn't turned
inside out.
I mean... if we had a "netdev_set_drivername()" thing with appropriate
arguments (well I suck at names, name it whatever you feel like), we
wouldn't need the drivers to implement each their own ethtool method,
since this could just be done in one place and pull the data from the
netdev.

(for the eeprom etc data that's different, but those are already
different ethtool methods last I looked)


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  reply	other threads:[~2008-07-08 23:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-06 20:08 Printing the driver name as part of the netdev watchdog message Arjan van de Ven
2008-07-06 22:53 ` David Miller
2008-07-06 23:56   ` Arjan van de Ven
2008-07-07  1:51     ` Wang Chen
2008-07-07  3:59       ` David Miller
2008-07-07  4:34         ` Arjan van de Ven
2008-07-07  4:49           ` David Miller
2008-07-07  4:57             ` Arjan van de Ven
2008-07-07  6:44               ` David Miller
2008-07-07 15:23                 ` Arjan van de Ven
2008-07-07  1:08   ` Stephen Hemminger
2008-07-07  1:22     ` David Miller
2008-07-07  1:53       ` Jeff Garzik
2008-07-07 17:05         ` Stephen Hemminger
2008-07-07 22:45       ` Roland Dreier
2008-07-07 22:57         ` David Miller
2008-07-07 23:14           ` Roland Dreier
2008-07-07 23:44             ` Stephen Hemminger
2008-07-08  0:10               ` Arjan van de Ven
2008-07-08 19:13             ` Steve Wise
2008-07-08 21:31               ` David Miller
2008-07-08 21:47                 ` Arjan van de Ven
2008-07-08 21:57                   ` David Miller
2008-07-08 23:48                     ` Arjan van de Ven [this message]
2008-07-08 23:53                       ` David Miller
2008-07-09  0:17                         ` Arjan van de Ven
2008-07-09  1:44                         ` Arjan van de Ven
2008-07-09  3:16                           ` Stephen Hemminger
2008-07-09 17:20                             ` Joe Perches
2008-07-09 17:56                               ` Arjan van de Ven
2008-07-09 18:20                                 ` Joe Perches
2008-07-09 18:50                                   ` Arjan van de Ven
2008-07-09 18:28                                 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708164826.2a2d52c2@infradead.org \
    --to=arjan@infradead.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=shemminger@vyatta.com \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).