Re: Printing the driver name as part of the netdev watchdog message

[Arjan van de Ven <arjan@infradead.org>]

On Tue, 08 Jul 2008 16:53:04 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Arjan van de Ven <arjan@infradead.org>
> Date: Tue, 8 Jul 2008 16:48:26 -0700
> 
> > On Tue, 08 Jul 2008 14:57:38 -0700 (PDT)
> > David Miller <davem@davemloft.net> wrote:
> > 
> > > What we need instead is to cache the info block into the netdev
> > > struct when the driver is ->open()'d, and then you can fetch it
> > > out of there however you like.
> > 
> > but.. isn't that like almost the same as using the object model
> > data at that point?
> 
> You're right, this is getting silly
> 
> > I mean... if we had a "netdev_set_drivername()" thing with
> > appropriate arguments (well I suck at names, name it whatever you
> > feel like), we wouldn't need the drivers to implement each their
> > own ethtool method, since this could just be done in one place and
> > pull the data from the netdev.
> > 
> > (for the eeprom etc data that's different, but those are already
> > different ethtool methods last I looked)
> 
> To be honest, the more I think about this, the driver->name should
> be sufficient.
> 
> I just checked a bunch of PCI drivers and they provide the
> same value for pci_driver->name as ethtool's info->driver
> 
> Sure, the ethtool info thing has a driver version etc. but
> for your purposes that really doesn't add much.

ok I'll get you a patch after dinner.



-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org