From: William Boughton <bill@boughton.de>
To: netdev@vger.kernel.org
Cc: stephen.hemminger@vyatta.com, Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [Oops] fib_trie with ip route add throw since 2.6.25
Date: Wed, 9 Jul 2008 06:55:41 +0200 [thread overview]
Message-ID: <20080709045541.GA26981@yuri.org.uk> (raw)
In-Reply-To: <20080707195744.GE28029@solarflare.com>
On Mon, Jul 07, 2008 at 08:57:45PM +0100, Ben Hutchings wrote:
Hello,
> [...]
>
> The changes to check_leaf() and fn_trie_lookup() seem to be wrong - where
> fn_trie_lookup() would previously return a negative error value from
> check_leaf(), it now returns 0.
>
> Now fn_trie_lookup() doesn't appear to care about plen, so we could revert
> check_leaf() to returning the error value. How does this work?
>
I have been running with this patch on 2.6.26-rc9 on a machine for
24 hours on a machine that caused the oops before without any problems.
regards
Bill
--
Bill Boughton
prev parent reply other threads:[~2008-07-09 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 18:41 [Oops] fib_trie with ip route add throw since 2.6.25 William Boughton
2008-07-07 19:57 ` Ben Hutchings
2008-07-07 20:12 ` Stephen Hemminger
2008-07-07 20:25 ` Ben Hutchings
2008-07-07 20:29 ` Patrick McHardy
2008-07-08 22:52 ` Stephen Hemminger
2008-07-09 4:55 ` William Boughton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709045541.GA26981@yuri.org.uk \
--to=bill@boughton.de \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).