From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: "Adam Langley" <agl@imperialviolet.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [RFC] mark MD5 as broken in older (stable) kernels
Date: Wed, 9 Jul 2008 09:58:51 -0700 [thread overview]
Message-ID: <20080709095851.1f9da054@speedy> (raw)
In-Reply-To: <396556a20805301217k293e5718h6bbf02bfe069001@europa>
The following should probably be sent to stable kernel tree to disable
MD5 in older kernels. It will avoid problems for all those vendor
kernels.
--- a/net/ipv4/Kconfig 2008-07-09 09:52:50.000000000 -0700
+++ b/net/ipv4/Kconfig 2008-07-09 09:54:27.000000000 -0700
@@ -622,7 +622,7 @@ config DEFAULT_TCP_CONG
config TCP_MD5SIG
bool "TCP: MD5 Signature Option support (RFC2385) (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && BROKEN
select CRYPTO
select CRYPTO_MD5
---help---
@@ -631,6 +631,8 @@ config TCP_MD5SIG
on the Internet.
If unsure, say N.
+ The current version is broken for case of TCP SACK and devices that
+ use TSO or Scatter/Gather.
source "net/ipv4/ipvs/Kconfig"
next prev parent reply other threads:[~2008-07-09 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 0:19 [PATCH] ipv[46]: Fix MD5 signatures for non-linear skbs Adam Langley
2008-07-04 4:05 ` Stephen Hemminger
2008-07-04 8:24 ` Evgeniy Polyakov
2008-07-07 17:21 ` Adam Langley
2008-07-07 17:22 ` Adam Langley
2008-07-07 18:22 ` Stephen Hemminger
2008-07-07 21:40 ` Adam Langley
2008-07-07 21:41 ` Adam Langley
2008-07-09 16:58 ` Stephen Hemminger [this message]
2008-07-09 17:01 ` [RFC] mark MD5 as broken in older (stable) kernels Adam Langley
2008-07-09 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709095851.1f9da054@speedy \
--to=stephen.hemminger@vyatta.com \
--cc=agl@imperialviolet.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).