From: Ben Hutchings <bhutchings@solarflare.com>
To: Patrick McHardy <kaber@trash.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 02/08]: vlan: deliver packets received with VLAN acceleration to network taps
Date: Wed, 9 Jul 2008 13:35:21 +0100 [thread overview]
Message-ID: <20080709123520.GK28029@solarflare.com> (raw)
In-Reply-To: <20080709120948.11669.98935.sendpatchset@localhost.localdomain>
Patrick McHardy wrote:
> vlan: deliver packets received with VLAN acceleration to network taps
>
> When VLAN header stripping is used, packets currently bypass packet
> sockets (and other network taps) completely. For locally existing
> VLANs, they appear directly on the VLAN device, for unknown VLANs
> they are silently dropped.
>
> Add a new function netif_nit_deliver() to deliver incoming packets
> to all network interface taps and use it in __vlan_hwaccel_rx() to
> make VLAN packets visible on the underlying device.
[...]
> +/*
> + * netif_tap_deliver - deliver received packets to network taps
> + * @skb: buffer
> + *
> + * This function is used to deliver incoming packets to network
> + * taps. It should be used when the normal netif_receive_skb path
> + * is bypassed, for example because of VLAN acceleration.
> + */
> +void netif_nit_deliver(struct sk_buff *skb)
[...]
Is it supposed to be called netif_nit_deliver() or netif_tap_deliver()?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-07-09 12:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 12:09 [PATCH 00/08]: VLAN update Patrick McHardy
2008-07-09 12:09 ` [PATCH 01/08]: vlan: Don't store VLAN tag in cb Patrick McHardy
2008-07-09 12:09 ` [PATCH 02/08]: vlan: deliver packets received with VLAN acceleration to network taps Patrick McHardy
2008-07-09 12:35 ` Ben Hutchings [this message]
2008-07-09 12:37 ` Patrick McHardy
2008-07-09 12:09 ` [PATCH 03/08]: packet: support extensible, 64 bit clean mmaped ring structure Patrick McHardy
2008-07-09 12:09 ` [PATCH 04/08]: packet: deliver VLAN TCI to userspace Patrick McHardy
2008-07-09 12:09 ` [PATCH 05/08]: vlan: ethtool ->get_flags support Patrick McHardy
2008-07-09 12:09 ` [PATCH 06/08]: vlan: clean up vlan_dev_hard_header() Patrick McHardy
2008-07-09 12:09 ` [PATCH 07/08]: vlan: clean up hard_start_xmit functions Patrick McHardy
2008-07-09 12:09 ` [PATCH 08/08]: vlan: remove unnecessary include statements Patrick McHardy
2008-07-09 12:12 ` [PATCH 00/08]: VLAN update Patrick McHardy
2008-07-15 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709123520.GK28029@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).