From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: bhutchings@solarflare.com, bill@boughton.de,
netdev@vger.kernel.org, stephen.hemminger@vyatta.com
Subject: Re: [PATCH] [IPV4] fib_trie: Fix lookup error return
Date: Thu, 10 Jul 2008 16:52:59 -0700 (PDT) [thread overview]
Message-ID: <20080710.165259.239070162.davem@davemloft.net> (raw)
In-Reply-To: <20080710105450.3ef6cd14@extreme>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 10 Jul 2008 10:54:50 -0700
> On Thu, 10 Jul 2008 14:23:37 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > In commit a07f5f508a4d9728c8e57d7f66294bf5b254ff7f "[IPV4] fib_trie: style
> > cleanup", the changes to check_leaf() and fn_trie_lookup() were wrong - where
> > fn_trie_lookup() would previously return a negative error value from
> > check_leaf(), it now returns 0.
> >
> > Now fn_trie_lookup() doesn't appear to care about plen, so we can revert
> > check_leaf() to returning the error value.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > Tested-by: William Boughton <bill@boughton.de>
>
> Acked-by: Stephen Heminger <shemminger@vyatta.com>
Applied, thanks everyone.
prev parent reply other threads:[~2008-07-10 23:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 13:23 [PATCH] [IPV4] fib_trie: Fix lookup error return Ben Hutchings
2008-07-10 17:54 ` Stephen Hemminger
2008-07-10 23:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710.165259.239070162.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bill@boughton.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).