From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] [IPV4] fib_trie: Fix lookup error return
Date: Thu, 10 Jul 2008 16:52:59 -0700 (PDT)
Message-ID: <20080710.165259.239070162.davem@davemloft.net>
References: <20080710132336.GO28029@solarflare.com>
	<20080710105450.3ef6cd14@extreme>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: bhutchings@solarflare.com, bill@boughton.de,
	netdev@vger.kernel.org, stephen.hemminger@vyatta.com
To: shemminger@vyatta.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50130
	"EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK)
	by vger.kernel.org with ESMTP id S1754798AbYGJXw6 (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 10 Jul 2008 19:52:58 -0400
In-Reply-To: <20080710105450.3ef6cd14@extreme>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 10 Jul 2008 10:54:50 -0700

> On Thu, 10 Jul 2008 14:23:37 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
> 
> > In commit a07f5f508a4d9728c8e57d7f66294bf5b254ff7f "[IPV4] fib_trie: style
> > cleanup", the changes to check_leaf() and fn_trie_lookup() were wrong - where
> > fn_trie_lookup() would previously return a negative error value from
> > check_leaf(), it now returns 0.
> >  
> > Now fn_trie_lookup() doesn't appear to care about plen, so we can revert
> > check_leaf() to returning the error value.
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > Tested-by: William Boughton <bill@boughton.de>
> 
> Acked-by: Stephen Heminger <shemminger@vyatta.com>

Applied, thanks everyone.