From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: linux-next: Tree for July 11 Date: Sat, 12 Jul 2008 22:26:09 +0200 Message-ID: <200807122226.10699.rjw@sisk.pl> References: <20080711182557.9b24df1f.sfr@canb.auug.org.au> <200807122051.50909.rjw@sisk.pl> <19f34abd0807121221n75fd7bb8x24fa484239773201@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: "Stephen Rothwell" , linux-next@vger.kernel.org, LKML , "Kernel Testers List" , netdev@vger.kernel.org, "Pekka Enberg" , "Jens Axboe" To: "Vegard Nossum" Return-path: In-Reply-To: <19f34abd0807121221n75fd7bb8x24fa484239773201@mail.gmail.com> Content-Disposition: inline Sender: linux-next-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Saturday, 12 of July 2008, Vegard Nossum wrote: > On Sat, Jul 12, 2008 at 8:51 PM, Rafael J. Wysocki wrote: > > and the second one is the following: > > > > WARNING: at /home/rafael/src/linux-next/include/linux/blkdev.h:447 blk_plug_device+0x9b/0xb0() > > Modules linked in: snd_hda_intel ohci1394 ieee1394 snd_pcm rtc_cmos sr_mod rtc_core floppy snd_timer wmi button cdrom rtc_lib serio_raw sky2 snd_page_alloc snd_hwdep snd evdev joydev sg soundcore raid456 async_xor async_memcpy async_tx xor raid0 usbhid ff_memless ehci_hcd ohci_hcd sd_mod edd raid1 ext3 jbd fan pata_marvell pata_atiixp thermal processor > > Pid: 2244, comm: kjournald Not tainted 2.6.26-rc9-next #44 > > > > Call Trace: > > [] warn_on_slowpath+0x5f/0x80 > > [] ? hpet_unregister_irq_handler+0x0/0x30 > > [] ? kmemcheck_mark_initialized+0xe/0x10 > > [] ? kmemcheck_slab_alloc+0x2b/0x50 > > [] ? kmem_cache_alloc+0xc0/0x140 > > [] ? mempool_alloc_slab+0x11/0x20 > > [] ? mempool_alloc+0x5b/0x140 > > [] blk_plug_device+0x9b/0xb0 > > [] bitmap_startwrite+0xbf/0x1b0 > > [] ? bio_alloc_bioset+0x54/0xb0 > > [] make_request+0x39a/0x810 [raid1] > > [] ? mempool_alloc+0x5b/0x140 > > [] ? mempool_alloc+0x5b/0x140 > > [] generic_make_request+0x17d/0x2b0 > > [] submit_bio+0x6c/0xf0 > > [] submit_bh+0xf0/0x130 > > [] journal_commit_transaction+0xa40/0x1000 [jbd] > > [] ? try_to_del_timer_sync+0x44/0x90 > > [] kjournald+0xe7/0x250 [jbd] > > [] ? autoremove_wake_function+0x0/0x40 > > [] ? kjournald+0x0/0x250 [jbd] > > [] kthread+0x4d/0x80 > > [] child_rip+0xa/0x11 > > [] ? _spin_unlock_irq+0x2b/0x40 > > [] ? restore_args+0x0/0x30 > > [] ? kthreadd+0x122/0x1a0 > > [] ? kthread+0x0/0x80 > > [] ? child_rip+0x0/0x11 > > Hm, even though there's kmemcheck in the stacktrace, I think it's > unrelated. Probably it's just a call that returned and the addresses > were left on the stack. You can also see that the warning clearly > comes from blkdev.h, and since kmemcheck does *not* call into any > blkdev stuff, those stacktrace entries must be just left-overs, as is > also indicated by the unreliable mark, so although those are wrong in > certain circumstances, I don't think they are in this case. > > The warning comes from here: > > static inline int queue_flag_test_and_set(unsigned int flag, > struct request_queue *q) > { > WARN_ON_ONCE(!queue_is_locked(q)); > > I'll add Jens Axboe to Cc. Yeah, good idea. :-) It turns out that this happened before, but I've been overlooking it. This is a trace from the Friday's linux-next: ------------[ cut here ]------------ WARNING: at /home/rafael/src/linux-next/include/linux/blkdev.h:447 blk_plug_device+0x9b/0xb0() Modules linked in: rtc_cmos snd_hda_intel rtc_core snd_pcm sr_mod floppy snd_timer snd_page_alloc rtc_lib ohci1394 serio_raw cdrom ieee1394 snd_hwdep snd soundcore sky2 button wmi joydev evdev sg raid456 async_xor async_memcpy async_tx xor raid0 usbhid ff_memless ehci_hcd sd_mod ohci_hcd edd raid1 ext3 jbd fan pata_marvell pata_atiixp thermal processor Pid: 2275, comm: kjournald Not tainted 2.6.26-rc9-next #40 Call Trace: [] warn_on_slowpath+0x5f/0x80 [] ? hpet_rtc_interrupt+0x100/0x380 [] ? __lock_acquire+0x8b7/0x1280 [] ? mempool_alloc_slab+0x11/0x20 [] blk_plug_device+0x9b/0xb0 [] bitmap_startwrite+0xbf/0x1b0 [] ? bio_alloc_bioset+0x54/0xb0 [] make_request+0x39a/0x810 [raid1] [] ? mempool_alloc+0x5b/0x140 [] ? mempool_alloc+0x5b/0x140 [] generic_make_request+0x17d/0x2b0 [] submit_bio+0x6c/0xf0 [] submit_bh+0xf0/0x130 [] journal_commit_transaction+0xa40/0x1000 [jbd] [] ? try_to_del_timer_sync+0x44/0x90 [] kjournald+0xe7/0x250 [jbd] [] ? autoremove_wake_function+0x0/0x40 [] ? kjournald+0x0/0x250 [jbd] [] kthread+0x4d/0x80 [] child_rip+0xa/0x11 [] ? restore_args+0x0/0x30 [] ? kthread+0x0/0x80 [] ? child_rip+0x0/0x11 ---[ end trace bd85cedf792d0f08 ]--- and the full dmesg is here: http://www.sisk.pl/kernel/debug/20080709/dmesg-1.log Thanks, Rafael