From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: bnx2_poll panicking kernel Date: Mon, 14 Jul 2008 19:20:55 +0200 Message-ID: <20080714172055.GA2638@ami.dom.local> References: <20080710223141.GA2519@orion.carnet.hr> <20080710.162007.04790623.davem@davemloft.net> <20080711092416.GA26515@orion.carnet.hr> <20080711.025656.261409874.davem@davemloft.net> <48787E1A.3030804@gmail.com> <4878AFD8.1000307@gmail.com> <487B7061.5040306@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , joy@entuzijast.net, mchan@broadcom.com, billfink@mindspring.com, bhutchings@solarflare.com, netdev@vger.kernel.org, mirrors@debian.org, devik@cdi.cz To: Patrick McHardy Return-path: Received: from gv-out-0910.google.com ([216.239.58.191]:36605 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757624AbYGNRVX (ORCPT ); Mon, 14 Jul 2008 13:21:23 -0400 Received: by gv-out-0910.google.com with SMTP id e6so887714gvc.37 for ; Mon, 14 Jul 2008 10:21:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <487B7061.5040306@trash.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jul 14, 2008 at 05:27:29PM +0200, Patrick McHardy wrote: > Jarek Poplawski wrote: >> Jarek Poplawski wrote, On 07/12/2008 11:49 AM: >> >>> This isn't correct: htb_activate() needs cl->un.leaf.q->q.qlen > 0, and >>> only NET_XMIT_SUCCESS can guarantee this. >> >> >> ...Actually, it looks like even NET_XMIT_SUCCESS can't guarantee this >> (when returned after TC_ACT_QUEUED or TC_ACT_STOLEN), so additional qlen >> test is needed here. > > The TC action code translation needs to be fixed instead. > > I didn't manage to work on this this weekend as I intended, but > I'll take care of it soon unless someone beats me to it. IMHO, since this TC_ACT_ issue looks quite rare, David's patch, with "htb_activate()" moved to the last "if (ret == NET_XMIT_SUCCESS)" blocks, looks like necessary. BTW, I wonder how Josip's testing? Jarek P.