From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: tomasw@gmail.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: pull request: wireless-next-2.6 2008-07-14
Date: Wed, 16 Jul 2008 16:05:52 -0400 [thread overview]
Message-ID: <20080716200552.GA28827@tuxdriver.com> (raw)
In-Reply-To: <20080716.130007.11761812.davem@davemloft.net>
On Wed, Jul 16, 2008 at 01:00:07PM -0700, David Miller wrote:
> From: "Tomas Winkler" <tomasw@gmail.com>
> Date: Wed, 16 Jul 2008 15:49:34 +0300
>
> > On Tue, Jul 15, 2008 at 6:45 AM, David Miller <davem@davemloft.net> wrote:
> > > From: "John W. Linville" <linville@tuxdriver.com>
> > > Date: Mon, 14 Jul 2008 15:23:02 -0400
> > >
> > > drivers/net/wireless/iwlwifi/iwl-led.c:271: warning: format '%lld' expects type 'long long int', but argument 6 has type 's64'
> > > drivers/net/wireless/iwlwifi/iwl-led.c:271: warning: format '%lld' expects type 'long long int', but argument 7 has type 'u64'
> >
> > I cannot reproduce this. Wasn't this conversion already solved or
> > still need to cast to long long int?
>
> You have to cast u64/s64 values to long long if you want to print them
> using %llX specifiers, because some 64-bit platforms define these
> types as plain "long".
There were a number of such warnings fixed in iwlwifi previously.
It is possible that either one got lost in a merge conflict or this
new one simply is reminding Tomas of one of the old ones. Either way,
it seems to be fixed now.
John
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2008-07-16 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 19:23 pull request: wireless-next-2.6 2008-07-14 John W. Linville
[not found] ` <20080714192302.GA2541-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2008-07-14 20:29 ` Randy Dunlap
2008-07-15 13:48 ` John W. Linville
[not found] ` <20080715134849.GA24361-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2008-07-15 16:24 ` Randy Dunlap
[not found] ` <20080715092431.d288d0e8.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-07-15 16:38 ` John W. Linville
2008-07-15 3:45 ` David Miller
[not found] ` <20080714.204532.116542087.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-15 7:43 ` Johannes Berg
[not found] ` <1216107805.23746.14.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-07-15 8:09 ` [PATCH] wireless: fix warnings from QoS patch Johannes Berg
[not found] ` <1216109364.23746.17.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-07-15 9:09 ` David Miller
2008-07-16 12:49 ` pull request: wireless-next-2.6 2008-07-14 Tomas Winkler
2008-07-16 20:00 ` David Miller
2008-07-16 20:05 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716200552.GA28827@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).