* [PATCH] net: missing lock initialization [not found] <20080718161048.678a9629@extreme> @ 2008-07-18 23:38 ` Stephen Hemminger 2008-07-19 0:49 ` David Miller 0 siblings, 1 reply; 2+ messages in thread From: Stephen Hemminger @ 2008-07-18 23:38 UTC (permalink / raw) Cc: David Miller, netdev Looks like the xmit_lock is not being initialized in net-next Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/core/dev.c 2008-07-18 16:31:16.000000000 -0700 +++ b/net/core/dev.c 2008-07-18 16:35:31.000000000 -0700 @@ -4175,6 +4175,7 @@ static void netdev_init_one_queue(struct struct netdev_queue *queue, void *_unused) { + spin_lock_init(&queue->_xmit_lock); queue->dev = dev; } ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: missing lock initialization 2008-07-18 23:38 ` [PATCH] net: missing lock initialization Stephen Hemminger @ 2008-07-19 0:49 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2008-07-19 0:49 UTC (permalink / raw) To: shemminger; +Cc: netdev From: Stephen Hemminger <shemminger@vyatta.com> Date: Fri, 18 Jul 2008 16:38:36 -0700 > Looks like the xmit_lock is not being initialized in net-next > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> I guess you can't find the call in __netdev_init_queue_locks_one(). With your patch we'll now be initializing it twice. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-19 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080718161048.678a9629@extreme>
2008-07-18 23:38 ` [PATCH] net: missing lock initialization Stephen Hemminger
2008-07-19 0:49 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).