From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: [PATCH 3/4] sfc: resolve tx multiqueue bug
Date: Fri, 18 Jul 2008 19:01:57 +0100 [thread overview]
Message-ID: <20080718180156.GH10471@solarflare.com> (raw)
In-Reply-To: <20080718175911.GF10471@solarflare.com>
With the recent changes to tx multiqueue, sfc was not calling
netif_start_queue() before calling netif_wake_queue().
This causes an oops when opening a device.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/tx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/sfc/tx.c b/drivers/net/sfc/tx.c
index 5cdd082..798b06b 100644
--- a/drivers/net/sfc/tx.c
+++ b/drivers/net/sfc/tx.c
@@ -53,6 +53,7 @@ inline void efx_wake_queue(struct efx_nic *efx)
if (atomic_dec_and_lock(&efx->netif_stop_count,
&efx->netif_stop_lock)) {
EFX_TRACE(efx, "waking TX queue\n");
+ netif_start_queue(efx->net_dev);
netif_wake_queue(efx->net_dev);
spin_unlock(&efx->netif_stop_lock);
}
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next prev parent reply other threads:[~2008-07-18 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 17:59 [PATCH 1/4] sfc: I2C adapter initialisation fixes Ben Hutchings
2008-07-18 18:01 ` [PATCH 2/4] sfc: Use a separate workqueue for resets Ben Hutchings
2008-07-18 18:01 ` Ben Hutchings [this message]
2008-07-18 18:49 ` [PATCH 3/4] sfc: resolve tx multiqueue bug Ben Hutchings
2008-07-22 18:41 ` Ben Hutchings
2008-07-22 21:00 ` David Miller
2008-07-22 21:29 ` Jeff Garzik
2008-07-22 21:33 ` David Miller
2008-07-18 18:03 ` [PATCH 4/4] sfc: Create one RX queue and interrupt per CPU package by default Ben Hutchings
2008-07-22 23:44 ` [PATCH 1/4] sfc: I2C adapter initialisation fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718180156.GH10471@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=jgarzik@pobox.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).