netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH 10/13]: net: Implement simple sw TX hashing.
Date: Sat, 19 Jul 2008 00:26:56 -0700 (PDT)	[thread overview]
Message-ID: <20080719.002656.186841207.davem@davemloft.net> (raw)
In-Reply-To: <487F7187.9060909@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Thu, 17 Jul 2008 18:21:27 +0200

> Actually I think we could just make the number of tx queues of
> virtual devices match the lower device and use the unencapsulated
> packets for queue selection.
> 
> Of course that would require not to perform queue selection
> again on the real device. For VLANs, macvlan etc. that don't
> do any locking internally that would probably make sense.

Agreed.

> Not sure about PPPoE.

PPPOE just sends down to dev_queue_xmit() with the new device
after encapsulating, and the network header is set correctly.
Therefore this case can just be left as-is.

      reply	other threads:[~2008-07-19  7:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 10:57 [PATCH 10/13]: net: Implement simple sw TX hashing David Miller
2008-07-11 20:49 ` Eric Dumazet
2008-07-14 11:33   ` Herbert Xu
2008-07-14 11:58     ` David Miller
2008-07-15  6:49       ` Eric Dumazet
2008-07-15  6:58         ` David Miller
2008-07-15 10:45         ` David Miller
2008-07-17 16:16 ` Stephen Hemminger
2008-07-17 16:21   ` Patrick McHardy
2008-07-19  7:26     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080719.002656.186841207.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).