* [PATCH -next] net namespace: build when SYSCTL=n
@ 2008-07-19 0:18 Randy Dunlap
2008-07-19 1:01 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-07-19 0:18 UTC (permalink / raw)
To: lkml; +Cc: netdev, davem
From: Randy Dunlap <randy.dunlap@oracle.com>
When CONFIG_SYSCTL=n, build fails with:
linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
include/net/net_namespace.h | 2 ++
1 file changed, 2 insertions(+)
--- linux-next-20080718.orig/include/net/net_namespace.h
+++ linux-next-20080718/include/net/net_namespace.h
@@ -37,7 +37,9 @@ struct net {
struct proc_dir_entry *proc_net;
struct proc_dir_entry *proc_net_stat;
+#ifdef CONFIG_SYSCTL
struct ctl_table_set sysctls;
+#endif
struct net_device *loopback_dev; /* The loopback */
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] net namespace: build when SYSCTL=n
2008-07-19 0:18 [PATCH -next] net namespace: build when SYSCTL=n Randy Dunlap
@ 2008-07-19 1:01 ` David Miller
2008-07-19 2:33 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-07-19 1:01 UTC (permalink / raw)
To: randy.dunlap; +Cc: linux-kernel, netdev
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Fri, 18 Jul 2008 17:18:12 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_SYSCTL=n, build fails with:
>
> linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
This 'sysctls' member isn't present in my networking tree, it must be
coming from some other tree and thus the patch needs to be applied
there.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] net namespace: build when SYSCTL=n
2008-07-19 1:01 ` David Miller
@ 2008-07-19 2:33 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2008-07-19 2:33 UTC (permalink / raw)
To: David Miller; +Cc: randy.dunlap, linux-kernel, netdev
On Fri, Jul 18, 2008 at 06:01:07PM -0700, David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Fri, 18 Jul 2008 17:18:12 -0700
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > When CONFIG_SYSCTL=n, build fails with:
> >
> > linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> This 'sysctls' member isn't present in my networking tree, it must be
> coming from some other tree and thus the patch needs to be applied
> there.
Yup. Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-19 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-19 0:18 [PATCH -next] net namespace: build when SYSCTL=n Randy Dunlap
2008-07-19 1:01 ` David Miller
2008-07-19 2:33 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).