From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: kaber@trash.net, netdev@vger.kernel.org,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU.
Date: Sun, 20 Jul 2008 16:59:11 -0700 (PDT) [thread overview]
Message-ID: <20080720.165911.86437240.davem@davemloft.net> (raw)
In-Reply-To: <1216593170.4847.137.camel@localhost>
From: jamal <hadi@cyberus.ca>
Date: Sun, 20 Jul 2008 18:32:50 -0400
> pfifo_fast would be a bad choice in that case, but even a pfifo cannot
> guarantee proper RR because it would present packets in a FIFO order
> (and example the first 10 could go to hardware queue1 and the next to
> hardware queue2).
Jamal, I have to wonder why are you so hung up on matching our
software qdiscs with whatever fairness algorithm the hardware happens
to implement internally for the TX queues?
Every time this topic comes up, you insist on them having to match.
And I have no idea why.
It's largely irrelevant and the TX queue can be viewed purely as a
buffer between us and the device, nearly a black hole we stick packets
into.
> > These things are built for parallelization, not prioritization.
>
> Total parallelization happens in the ideal case. If X cpus classify
> packets going to X different hardware queueus each CPU grabs only locks
> for that hardware queue.
The problem is that the bottleneck is the qdisc itself since all those
cpus synchonize on it's lock. We can't have a shared qdisc for the
device and get full parallelization.
That's why we're having one qdisc per TX queue, so that they all don't
bunch up on the qdisc lock.
Otherwise, there is zero point in all of these TX multiqueue features
in the hardware if we can't parallelize things fully.
next prev parent reply other threads:[~2008-07-20 23:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 12:17 [PATCH 20/31]: pkt_sched: Perform bulk of qdisc destruction in RCU David Miller
[not found] ` <20080717.051726.226040470.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-17 13:03 ` Patrick McHardy
[not found] ` <487F4327.1000107-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-17 13:12 ` David Miller
2008-07-17 13:48 ` Patrick McHardy
[not found] ` <487F4DA6.6010009-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-17 22:36 ` David Miller
[not found] ` <20080717.153609.142867331.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-17 23:58 ` Patrick McHardy
2008-07-17 13:35 ` jamal
2008-07-17 14:02 ` Patrick McHardy
[not found] ` <487F50EC.80008-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-17 22:24 ` David Miller
[not found] ` <20080717.152447.89672084.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-17 23:48 ` Patrick McHardy
2008-07-18 13:10 ` jamal
2008-07-18 13:27 ` jamal
2008-07-18 21:05 ` David Miller
2008-07-20 15:16 ` jamal
2008-07-20 17:25 ` David Miller
[not found] ` <20080720.102534.246150854.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-20 17:34 ` Tomas Winkler
[not found] ` <1ba2fa240807201034u1fbe3343tdcc858f7772d2b39-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-20 17:35 ` David Miller
2008-07-20 22:32 ` jamal
2008-07-20 23:59 ` David Miller [this message]
2008-07-21 2:20 ` jamal
2008-07-21 11:20 ` jamal
2008-07-21 16:45 ` David Miller
2008-07-21 11:58 ` Herbert Xu
[not found] ` <E1KKu2D-0002kd-00-XQvu0L+U/CjiRBuR/1fSEKKkPtS2pBon@public.gmane.org>
2008-07-21 13:08 ` jamal
2008-07-21 13:19 ` Herbert Xu
2008-07-21 13:56 ` jamal
2008-07-21 13:58 ` Herbert Xu
[not found] ` <20080721135846.GA11543-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-07-21 15:09 ` David Miller
[not found] ` <20080721.080901.214889979.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-21 15:22 ` Herbert Xu
2008-07-21 15:26 ` David Miller
[not found] ` <20080721.082627.128593651.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-21 16:16 ` Herbert Xu
[not found] ` <20080721161616.GA12938-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-07-21 16:25 ` David Miller
2008-07-21 16:43 ` Herbert Xu
2008-07-21 16:51 ` David Miller
[not found] ` <20080721.095124.89249903.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-21 17:02 ` Herbert Xu
[not found] ` <20080721170233.GA13417-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-07-21 17:08 ` David Miller
[not found] ` <20080721.100821.38432201.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-21 17:11 ` Herbert Xu
2008-08-22 6:56 ` Herbert Xu
2008-08-22 7:16 ` David Miller
[not found] ` <20080822.001620.141235108.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-22 7:41 ` Herbert Xu
[not found] ` <20080822074115.GB25615-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-08-22 10:42 ` David Miller
[not found] ` <20080822.034217.135152551.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-08-22 10:47 ` Herbert Xu
2008-08-22 13:52 ` jamal
[not found] ` <20080822065655.GA18471-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-08-22 13:43 ` jamal
2008-07-21 17:35 ` David Miller
2008-07-18 17:10 ` Roland Dreier
[not found] ` <adaljzz6ruq.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2008-07-20 14:58 ` jamal
2008-07-20 14:32 ` Herbert Xu
2008-07-20 17:20 ` David Miller
2008-07-20 14:20 ` Herbert Xu
[not found] ` <E1KKZmE-0000ty-00-XQvu0L+U/CjiRBuR/1fSEKKkPtS2pBon@public.gmane.org>
2008-07-20 15:35 ` jamal
2008-07-21 0:11 ` Herbert Xu
[not found] ` <20080721001119.GA6515-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-07-21 2:33 ` jamal
2008-07-21 3:17 ` Herbert Xu
2008-07-21 11:14 ` jamal
2008-07-21 11:36 ` Herbert Xu
[not found] ` <20080721113600.GA10322-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2008-07-21 11:39 ` jamal
2008-07-19 3:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720.165911.86437240.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=johannes@sipsolutions.net \
--cc=kaber@trash.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).