From: David Miller <davem@davemloft.net>
To: avorontsov@ru.mvista.com
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] gianfar: do not touch net queue in adjust_link phylib callback
Date: Mon, 21 Jul 2008 08:30:10 -0700 (PDT) [thread overview]
Message-ID: <20080721.083010.133624499.davem@davemloft.net> (raw)
In-Reply-To: <20080721151721.GA7989@polina.dev.rtsoft.ru>
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Mon, 21 Jul 2008 19:17:21 +0400
> If the net queue has not been started, we'll get this nice oops
> and non-working ethernet:
...
> Since the driver is using phylib (which is doing netif_carrier_on/off()),
> we should simply remove netif_tx_schedule_all() from adjust_link().
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Applied, thanks Anton.
prev parent reply other threads:[~2008-07-21 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 15:17 [PATCH 1/3] gianfar: do not touch net queue in adjust_link phylib callback Anton Vorontsov
2008-07-21 15:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721.083010.133624499.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avorontsov@ru.mvista.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).