netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* include/linux/ipv6.h, struct ipv6_devconf  leaks to userspace
@ 2008-07-21 12:34 Olaf Hering
  2008-07-21 20:42 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2008-07-21 12:34 UTC (permalink / raw)
  To: netdev


Found by make O="$header_dir" headers_install_all in 2.6.26:

struct ipv6_devconf contains conditional members, guarded by CONFIG_*.

Please move the struct into #ifdef __KERNEL__


Olaf

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: include/linux/ipv6.h, struct ipv6_devconf leaks to userspace
  2008-07-21 12:34 include/linux/ipv6.h, struct ipv6_devconf leaks to userspace Olaf Hering
@ 2008-07-21 20:42 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-21 20:42 UTC (permalink / raw)
  To: olaf; +Cc: netdev

From: Olaf Hering <olaf@aepfle.de>
Date: Mon, 21 Jul 2008 14:34:30 +0200

> 
> Found by make O="$header_dir" headers_install_all in 2.6.26:
> 
> struct ipv6_devconf contains conditional members, guarded by CONFIG_*.
> 
> Please move the struct into #ifdef __KERNEL__

I've applied the following patch, let me know if it doesn't
fix the problem.

Thanks.

ipv6: __KERNEL__ ifdef struct ipv6_devconf

Based upon a report by Olaf Hering.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/linux/ipv6.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
index 391ad08..641e026 100644
--- a/include/linux/ipv6.h
+++ b/include/linux/ipv6.h
@@ -123,6 +123,7 @@ struct ipv6hdr {
 	struct	in6_addr	daddr;
 };
 
+#ifdef __KERNEL__
 /*
  * This structure contains configuration options per IPv6 link.
  */
@@ -167,6 +168,7 @@ struct ipv6_devconf {
 	__s32		accept_dad;
 	void		*sysctl;
 };
+#endif
 
 /* index values for the variables in ipv6_devconf */
 enum {
-- 
1.5.6.4.433.g09651


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-21 20:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 12:34 include/linux/ipv6.h, struct ipv6_devconf leaks to userspace Olaf Hering
2008-07-21 20:42 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).