From: Andy Gospodarek <andy@greyhouse.net>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
David Woodhouse <dwmw2@infradead.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] tehuti: use request_firmware
Date: Tue, 22 Jul 2008 13:39:14 -0400 [thread overview]
Message-ID: <20080722173914.GH32408@gospo.rdu.redhat.com> (raw)
In-Reply-To: <1216741806.28669.6.camel@jaswinder.satnam>
On Tue, Jul 22, 2008 at 09:20:06PM +0530, Jaswinder Singh wrote:
>
> Firmware blob is little endian.
>
> Removed bdx_firmware_endianess() as firmware blob is already little endian
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
> drivers/net/tehuti.c | 29 +-
> drivers/net/tehuti.h | 1 +
> drivers/net/tehuti_fw.h |10712 ------------------------------------------
> firmware/Makefile | 1 +
> firmware/WHENCE | 12 +
> firmware/tehuti/bdx.bin.ihex | 2678 +++++++++++
> 6 files changed, 2708 insertions(+), 10725 deletions(-)
> delete mode 100644 drivers/net/tehuti_fw.h
> create mode 100644 firmware/tehuti/bdx.bin.ihex
>
This has been on my TODO list for a while, but just haven't gotten
around to it yet since I didn't feel like it was that crucial. Thanks
for taking the time, Jaswinder. Did you manage to test it?
I would like to try it out before ACKing, so I'll do that tonight or
tomorrow and post back my results.
next prev parent reply other threads:[~2008-07-22 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 15:50 [PATCH] tehuti: use request_firmware Jaswinder Singh
2008-07-22 17:39 ` Andy Gospodarek [this message]
2008-07-22 19:22 ` Jaswinder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722173914.GH32408@gospo.rdu.redhat.com \
--to=andy@greyhouse.net \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox