Re: [PATCH 3/4] sfc: resolve tx multiqueue bug

[Ben Hutchings <bhutchings@solarflare.com>]

The more I look at this issue of start vs wake, the more it seems like the
distinction should not be visible to drivers.

So long as a queue is only woken in response to TX completions, the current
arrangement is fine.  However, sfc needs to tear down and restart hardware TX
queues as part of some reconfiguration, self-test and recovery code, and I
doubt it's the only such driver.

I think the corresponding kernel queue must be stopped and then started when
we do this (otherwise we could return NETDEV_TX_BUSY in hard_start_xmit, but
I understand that to be deprecated).  So we must also wake the kernel queue
if and only if it's considered active - but we don't know whether that's the
case because deactivation is done asynchronously.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.