* [PATCH] sky2: don't stop queue on shutdown
@ 2008-07-23 4:50 Stephen Hemminger
2008-07-23 4:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2008-07-23 4:50 UTC (permalink / raw)
To: David Miller, Jeff Garzik; +Cc: netdev
It is unnecessary, to stop queue and turn off carrier in shutdown
routine. With new netdev_queue this causes warnings.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2008-07-22 15:00:19.000000000 -0700
+++ b/drivers/net/sky2.c 2008-07-22 16:16:53.000000000 -0700
@@ -1829,9 +1829,6 @@ static int sky2_down(struct net_device *
if (netif_msg_ifdown(sky2))
printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
- /* Stop more packets from being queued */
- netif_stop_queue(dev);
-
/* Disable port IRQ */
imask = sky2_read32(hw, B0_IMSK);
imask &= ~portirq_msk[port];
@@ -1887,8 +1884,6 @@ static int sky2_down(struct net_device *
sky2_phy_power_down(hw, port);
- netif_carrier_off(dev);
-
/* turn off LED's */
sky2_write16(hw, B0_Y2LED, LED_STAT_OFF);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sky2: don't stop queue on shutdown
2008-07-23 4:50 [PATCH] sky2: don't stop queue on shutdown Stephen Hemminger
@ 2008-07-23 4:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-23 4:53 UTC (permalink / raw)
To: shemminger; +Cc: jgarzik, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 22 Jul 2008 21:50:42 -0700
> It is unnecessary, to stop queue and turn off carrier in shutdown
> routine. With new netdev_queue this causes warnings.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-23 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-23 4:50 [PATCH] sky2: don't stop queue on shutdown Stephen Hemminger
2008-07-23 4:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).