From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98() Date: Wed, 23 Jul 2008 13:14:41 -0700 (PDT) Message-ID: <20080723.131441.200166513.davem@davemloft.net> References: <1216806614.7257.152.camel@twins> <20080723101352.GD4561@ff.dom.local> <1216810696.7257.175.camel@twins> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jarkao2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org, kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Return-path: In-Reply-To: <1216810696.7257.175.camel@twins> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Peter Zijlstra Date: Wed, 23 Jul 2008 12:58:16 +0200 > So I guess my question is, is netif_tx_lock() here to stay, or is the > right fix to convert all those drivers to use __netif_tx_lock() which > locks only a single queue? It's staying. It's trying to block all potential calls into the ->hard_start_xmit() method of the driver, and the only reliable way to do that is to take all the TX queue locks. And in one form or another, we're going to have this "grab/release all the TX queue locks" construct. I find it interesting that this cannot be simply described to lockdep :-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html