netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: francois.valenduc@tvcablenet.be, akpm@linux-foundation.org,
	bugme-daemon@bugzilla.kernel.org, linux-wireless@vger.kernel.org,
	linville@tuxdriver.com, netdev@vger.kernel.org,
	jussi.kivilinna@mbnet.fi
Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965
Date: Wed, 23 Jul 2008 14:21:47 -0700 (PDT)	[thread overview]
Message-ID: <20080723.142147.61941255.davem@davemloft.net> (raw)
In-Reply-To: <48875B8C.2090800@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Wed, 23 Jul 2008 18:25:48 +0200

> We can't fit them into the cb together, I don't see a way to
> shrink ieee80211_tx_info.
> 
> Maybe one of the wireless folks can suggest something? Is it
> really necessary to pass the full struct ieee80211_tx_info
> through the qdisc layer, or could the struct be split? It
> needs to find a way to co-exist peacefully with qdiscs'
> skb->cb usage.

This is another area that got mangled up in the ->select_queue()
conversion of the WME bits, but in another aspect this problem
existed beforehand as well.

Specifically, when RX packets get requeued out to transmit in
the code in net/mac80211/rx.c that resends packets back out the
wireless device by setting a bit in the SKB CB then calling
dev_queue_xmit().

That's completely illegal :-)

There's a ton of stuff in that structure, I can't see how to
make it smaller either.  Maybe some bits only matter through
the layers of the TX mac80211 stack and thus can be passed
as parameters during such processing?


  reply	other threads:[~2008-07-23 21:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-11144-10286@http.bugzilla.kernel.org/>
2008-07-22 10:48 ` [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965 Andrew Morton
2008-07-22 10:52   ` Patrick McHardy
     [not found]   ` <20080722034850.dbbc5566.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-23  7:58     ` François Valenduc
2008-07-23  7:59       ` François Valenduc
     [not found]       ` <4886E49D.6010700-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23  8:05         ` Andrew Morton
     [not found]           ` <20080723010522.389a948f.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-23  9:17             ` François Valenduc
     [not found]               ` <4886F727.6010301-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 10:12                 ` Patrick McHardy
     [not found]                   ` <48870425.50908-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 11:29                     ` François Valenduc
     [not found]                       ` <48871632.3010205-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 11:31                         ` Patrick McHardy
2008-07-23 11:58                           ` François Valenduc
     [not found]                           ` <4887169B.6090102-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 12:36                             ` François Valenduc
2008-07-23 12:44                               ` Patrick McHardy
     [not found]                                 ` <488727B3.7040007-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 12:51                                   ` Patrick McHardy
2008-07-23 14:57                                     ` François Valenduc
2008-07-23 15:18                                       ` Patrick McHardy
2008-07-23 15:19                                         ` Patrick McHardy
2008-07-23 15:42                                           ` François Valenduc
     [not found]                                             ` <4887514C.6080903-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 15:52                                               ` Patrick McHardy
2008-07-23 15:58                                                 ` François Valenduc
2008-07-23 15:59                                                   ` Patrick McHardy
2008-07-23 16:25                                                     ` Patrick McHardy
2008-07-23 21:21                                                       ` David Miller [this message]
     [not found]                                                         ` <20080723.142147.61941255.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-24  8:58                                                           ` Patrick McHardy
     [not found]                                                             ` <48884451.1090703-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-24 10:17                                                               ` Tomas Winkler
     [not found]                                                                 ` <1ba2fa240807240317g15f6ba84h91b513cce75975e9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-24 10:19                                                                   ` Patrick McHardy
     [not found]                                                                     ` <48885743.8030505-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-24 11:35                                                                       ` Tomas Winkler
     [not found]                                                                         ` <1ba2fa240807240435g36daa80at254144afffc39c32-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-24 11:45                                                                           ` Johannes Berg
2008-07-30 18:04                                                                             ` François Valenduc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080723.142147.61941255.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=francois.valenduc@tvcablenet.be \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=kaber@trash.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).