From: David Miller <davem@davemloft.net>
To: opurdila@ixiacom.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] net: per skb control messages
Date: Thu, 24 Jul 2008 14:56:00 -0700 (PDT) [thread overview]
Message-ID: <20080724.145600.30988015.davem@davemloft.net> (raw)
In-Reply-To: <200807250049.46939.opurdila@ixiacom.com>
From: Octavian Purdila <opurdila@ixiacom.com>
Date: Fri, 25 Jul 2008 00:49:46 +0300
> On Thursday 24 July 2008, David Miller wrote:
>
> > Adding new fields to struct sk_buff that take up space is generally
> > not allowed unless the new field adds substantially to the benefit of
> > a large group of users of Linus.
> >
> > I don't think that applied here for this hw-tstamps stuff.
>
> What about the approach proposed in the patch? Is it ok to add a pointer which
> may resolve other future similar issues?
Traversing the list and maintaining the reference counting and sharing
issues is expensive and error prone.
This is what OpenBSD uses for their IPSEC state attached to MBUFs and
it's a nightmare.
We have a timestamp in the SKB already, why don't you simply override
it when your feature is enable and set a single flag bit that
indicates you used a HW timestamp to set that timestamp?
next prev parent reply other threads:[~2008-07-24 21:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 22:01 [RFC][PATCH 0/3] net: per skb control messages Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 1/3] " Octavian Purdila
2008-07-24 12:46 ` Herbert Xu
2008-07-24 13:34 ` Octavian Purdila
2008-07-24 15:01 ` Herbert Xu
2008-07-24 16:22 ` Octavian Purdila
2008-07-24 20:28 ` David Miller
2008-07-24 21:49 ` Octavian Purdila
2008-07-24 21:56 ` David Miller [this message]
2008-07-24 21:58 ` Stephen Hemminger
2008-07-24 22:35 ` Octavian Purdila
2008-07-24 23:05 ` Stephen Hemminger
2008-07-24 22:12 ` Octavian Purdila
2008-07-24 22:17 ` David Miller
2008-07-24 23:14 ` Octavian Purdila
2008-07-24 23:18 ` David Miller
2008-07-24 23:26 ` Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 2/3] ip: support for SOL_SKB control messages for UDP/RAW sockets Octavian Purdila
2008-07-23 22:01 ` [RFC][PATCH 3/3] net: add SKB_SOL control messages Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724.145600.30988015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).