netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
	denys@visp.net.lb, netdev@vger.kernel.org
Subject: [PATCH] pkt_sched: sch_sfq: revert "dump a real number of flows" patch
Date: Thu, 24 Jul 2008 10:53:52 +0000	[thread overview]
Message-ID: <20080724105352.GB3946@ff.dom.local> (raw)
In-Reply-To: <488851FB.4080407@trash.net>

On Thu, Jul 24, 2008 at 11:57:15AM +0200, Patrick McHardy wrote:
...
> IIRC the ESFQ for SFQ patches even use
> "flows" in ->init, so it might make things a bit more ugly if we
> ever merge those patches.

This argument looks right to me.

David, please, apply this reverting patch.

Thanks,
Jarek P.

-------------------->

pkt_sched: sch_sfq: revert "dump a real number of flows" patch

Patrick McHardy <kaber@trash.net> noticed that since "flows" could be
used by sfq in the future as a parameter, we shouldn't currently
change it's meaning. This patch reverts my previous patch:
commit f867e6af94239a04ec23aeec2fcda5aa58e41db7


Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>

---

diff -Nurp net-2.6-/net/sched/sch_sfq.c net-2.6+/net/sched/sch_sfq.c
--- net-2.6-/net/sched/sch_sfq.c	2008-07-24 10:26:08.000000000 +0000
+++ net-2.6+/net/sched/sch_sfq.c	2008-07-21 09:32:53.000000000 +0000
@@ -536,14 +536,7 @@ static int sfq_dump(struct Qdisc *sch, s
 
 	opt.limit = q->limit;
 	opt.divisor = SFQ_HASH_DIVISOR;
-	opt.flows = 0;
-	if (q->tail != SFQ_DEPTH) {
-		unsigned int i;
-
-		for (i = 0; i < SFQ_HASH_DIVISOR; i++)
-			if (q->ht[i] != SFQ_DEPTH)
-				opt.flows++;
-	}
+	opt.flows = q->limit;
 
 	NLA_PUT(skb, TCA_OPTIONS, sizeof(opt), &opt);
 

  reply	other threads:[~2008-07-24 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-28 19:02 SFQ depth limit Denys Fedoryshchenko
2008-06-29 19:11 ` [PATCH] " Jarek Poplawski
2008-06-29 19:38   ` Denys Fedoryshchenko
2008-07-24  4:34   ` David Miller
2008-07-24  8:45     ` Patrick McHardy
2008-07-24  9:49       ` Jarek Poplawski
2008-07-24  9:57         ` Patrick McHardy
2008-07-24 10:53           ` Jarek Poplawski [this message]
2008-07-26  9:29             ` [PATCH] pkt_sched: sch_sfq: revert "dump a real number of flows" patch David Miller
2008-07-26 10:58               ` Jarek Poplawski
2008-07-27  0:24                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080724105352.GB3946@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=denys@visp.net.lb \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).