From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 4/4] sky2: Adapt sky2 to use reworked PCI PM Date: Thu, 24 Jul 2008 13:52:18 -0700 Message-ID: <200807241352.18947.jbarnes@virtuousgeek.org> References: <200807191436.40726.rjw@sisk.pl> <20080720190742.84258d7e.akpm@linux-foundation.org> <200807242250.51119.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , LKML , Jeff Garzik , pm list , netdev@vger.kernel.org, Stephen Hemminger To: "Rafael J. Wysocki" Return-path: In-Reply-To: <200807242250.51119.rjw@sisk.pl> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday, July 24, 2008 1:50 pm Rafael J. Wysocki wrote: > [Sorry for the delayed response, I'm at OLS.] > > On Monday, 21 of July 2008, Andrew Morton wrote: > > On Sat, 19 Jul 2008 14:42:51 +0200 "Rafael J. Wysocki" wrote: > > > Adapt the sky2 driver to use the reworked PCI PM. > > > > I fixed the rejects in "[PATCH 3/4] tg3: Adapt tg3 to use reworked PCI > > PM code" but this patch has too many for me to want to fix them. > > > > As usual, please at least take a look at what's in linux-next before > > going and bypassing all that queued work. > > Sorry for that. > > Appended is a version of the patch applying to the current mainline on top > of patches 1/4 - 3/4 without rejects. > > BTW, the sky2's WOL is broken on my test box because of commit > db99b98885e717454feef1c6868b27d3f23c2e7c ("sky2: put PHY in sleep when > down") that causes the box to hang solid in sky2_suspend() and > sky2_shutdown() after WOL has been enabled with 'ethtool -s eth0 wol g'. > > This has already been reported to Stephen and Jeff. Btw, I just asked Linus to pull the 2/4 part of this patchset, so the rest should be able to go upstream soon. Thanks, Jesse